Antoine Pitrou

Results 822 comments of Antoine Pitrou

Sorry, I approved while the two comments should probably be addressed before merging this.

> Ah, this will not work. If we want to remove `ObjectType` and `FileStatistics` from io/hdfs.h and instead use FileSystem API, then filesystem component would have to be enabled by...

Hi @AlenkaF > * Some C++ tests are failing in `hdfs_test`, with the following error: I think you're misreading the output, the test is actually skipped when the driver fails...

> * The MSVC compiler is complaining about a forward-declared friend function I'm using in `hdfs.cc`. Do you have any advice on how to better organise this? Hmm, rather than...

Issue resolved by pull request 44493 https://github.com/apache/arrow/pull/44493

We might be seeing a related issue on the Apache Arrow CI when trying to bump mimalloc from 2.0.6 (which works fine) to either 2.1.9 or 2.2.3 (both of which...

Here's the [test log](https://github.com/pitrou/arrow/actions/runs/14175925271/job/39710682207#step:10:5099) by the way, but it's not very insightful... though the "0x2000000" alignment is weird, is it expected? ``` tests/test_convert_builtin.py::test_array_to_pylist_roundtrip SKIPPED mimalloc: warning: unable to allocate aligned...

Ok, I've tested several versions now and I've determined that the crash appears with 2.1.9. Versions 2.1.7 and older are fine. Should I open a new issue for it?

Hmm, I don't know how you do the tags on mimalloc, but if I ask git to bisect between `v2.1.7` and `v2.1.9`, it tells me try to a changeset around...

Ok, it seems the last good commit is 75459a1bd72bf739bc084647e4a0fb20f91e6c9e and the first bad commit is a1cfe9667c307a355c13b6f8381463e04ad6b04d.