Antoine Pitrou
Antoine Pitrou
@assignUser @raulcd @kou @nealrichardson
Yes, I think we can probably close now. Thanks for doing this!
Some of those distributions return vectors, which wasn't possible in nopython mode when the random module was first implemented. We would actually have to add the possibility of return random...
multinomial is now supported as of PR #1758.
I took a quick look and here are some assorted thoughts: * there are no unit tests * only the encryption key needs to be on S3Options, not the MD5...
Also, for the other readers wondering, I've found a useful (though possibly outdated?) comparison of S3 encryption options here: https://www.linkedin.com/pulse/delusion-s3-encryption-benefits-ravi-ivaturi/
In your PR, it appears that `S3Options.sse_customer_key` expects a base64-encoded private key. Instead, why not expect the raw 256-bit key?
It appears that boto3 (the officiel Python bindings for AWS) expects the 32-byte raw key, example: https://github.com/boto/boto3/issues/1941#issuecomment-487211835
I think it's ok to switch the tests to access Minio using HTTPS with a self-signed certificate.
> do you know why the minio server is started with http rather than https? Just because it was easier :-) No particular reason otherwise.