Antoine Pitrou

Let's see... `ClientWithAsyncTemplateMethods` is a CRTP class, and `Aws::S3::S3Client` derives from `ClientWithAsyncTemplateMethods`. The `ClientWithAsyncTemplateMethods` constructor looks like this: ```c++ ClientWithAsyncTemplateMethods() : m_isInitialized(true), m_operationsProcessed(0) { AwsServiceClientT* pThis = static_cast(this); Aws::Utils::ComponentRegistry::RegisterComponent(AwsServiceClientT::GetServiceName(), pThis,...

I've reported this upstream at https://github.com/aws/aws-sdk-cpp/issues/3464

Issue resolved by pull request 46992 https://github.com/apache/arrow/pull/46992

Well, you could just add a constant, e.g.: ```c++ template void Hashing32::HashIntImp(uint32_t num_keys, const T* keys, uint32_t* hashes) { constexpr uint64_t kMultiplier = 11400714785074694791ULL; constexpr uint64_t kAddend = 9756277977048271785ULL; for...

@zanmato1984 @bkietz @paleolimbot What do you think?

Ah, clang is being picky. ``` /Users/runner/work/arrow/arrow/cpp/src/arrow/status.h:363:16: error: cannot pass object of non-trivial type 'arrow::Status' through variadic method; call will abort at runtime [-Wnon-pod-varargs] on_error(*this); ^ /Users/runner/work/arrow/arrow/cpp/src/parquet/arrow/writer.cc:392:31: note: in instantiation...

> The behaviour seems to line up exactly with Rust's `.or_else()` You can guess it's intended :)

@github-actions crossbow submit -g cpp

@github-actions crossbow submit -g cpp

@zanmato1984 @paleolimbot @bkietz I've tried to address all your comments and suggestions, can you take a look again?