Antoine Pitrou

Results 823 comments of Antoine Pitrou

@raulcd This is a possible candidate for 15.0.2, but not critical.

@wgtmac @etseidl @gszadovszky This is a draft PR. It works fine on the integration test but still needs unit tests. Since I'm quite new to this codebase (and to Java...

This is ready for review now. The only failing test is the interop test, since the [required file](https://github.com/apache/parquet-testing/pull/46) is not in parquet-testing yet (I have checked it passes locally).

For the record, I must still address some of the review comments.

@gszadovszky I think I addressed your comments, could you take another look?

@github-actions crossbow submit -g python -g cpp

Question: the caching was probably there for a reason, is it ok to remove it? Would it be beneficial to reimplement it in a thread-safe way? (the PR description mentions...

Hmm, I was assuming the Cython compatibility issues were fixed? @raulcd

Ah, that's because this PR needs rebasing. @tolleybot Can you please rebase/merge on git main?

@github-actions crossbow submit -g python -g cpp