Peter Jaszkowiak

If somebody wants to open an issue on benchpress I can switch it to use musl-libc instead which should make it more portable across Linux distros.

Sounds like a CORS sorta thing. Where else did you try it?

The default jpeg output quality is `80`: https://sharp.pixelplumbing.com/api-output#jpeg That might be something we want to change or make configurable.

Your PR is never going to fly as is. You probably only saw a quality improvement because you're no longer going through sharp at all.

You can implement just exif stripping in a plugin like https://github.com/NodeBB/nodebb-plugin-imagemagick if that's what you really want. But I think there's some weird stuff going on in our image library....

As for what to do about your PR: I suggest changing it to just set the quality to 100 for jpegs and pngs when stripping exif data. See resize for...

You'd turn off exif stripping in the ACP and do it in your plugin instead. I doubt that setting quality to 100 will bloat the images, but I can't tell...

Detecting the quality of an input jpeg is a hard problem: https://gist.github.com/FranckFreiburger/d8e7445245221c5cf38e69a88f22eeeb But we could do something like this to try to output a jpeg at the same quality of...

You could "just strip exif data but orientation" but that won't work if you need to resize the image anyways, and support for exif orientation in browsers isn't great.

Are certain characters not allowed in http headers? I guess I'm wondering why an apostrophe, for instance, is such an issue in a non-standard header.