Peter Jaszkowiak

Results 182 comments of Peter Jaszkowiak

As I understand it, the behavior where `RangeFrom` overflows at the extreme is a consequence of the range types implementing `Iterator` directly. In order to prevent the overflow and stop...

All that said, it would be good to have a lint for this. Please open a clippy issue for that.

Well, one problem is that the iterator can only ever yield `0..=MAX-1` because to yield the maximum it needs to increment the iterator state past it. So the lint can...

If you try to use `break;` outside loops or switch statements, it results in SyntaxError: unlabeled break must be inside loop or switch Here's an example: ```js { console.log(1); break;...

Man I've taken a while to respond, sorry about that. First, I'd like to put some numbers on it. Of the top 1000 rust repositories (when I took this poll):...

Thank you for your thoughtful response. I look forward to working together in the future to hopefully improve this default.

I'm pretty sure the change he was referring to was "if..else can now be used in expression position"

Agreed, please outline the exact function signatures for `WakerBuilder` and any added or changed functions and fields for `Context`. I am wondering if a builder is really warranted here. Do...

Do we want to allow constructing a `Context` with only a `LocalWaker` (no `Waker`)? In that case, calling `.waker()` would panic? Can we somehow make that a monomorphization error instead?

I'm a little confused. > I doubt it, contexts would be entirely dynamic with respect to their `Waker` support. You're saying you doubt it would be possible to make this...