Peter Jaszkowiak
Peter Jaszkowiak
r? xFrednet since they reviewed the last one. Also, CC @Centri3
Thanks for taking a look. It seems like the next toolchain update should be on the 7th, which should include all the necessary diagnostic items. I've made the changes you...
Welp, in working on the implementation I discovered that the diag items were still incomplete. So I guess we'll wait another two weeks 🙃
@rustbot ready
@ytmimi > This means that the `style_edition` specified on the command line has the highest priority, followed by explicitly setting `style_edition` in `rustfmt.toml` followed by edition specified on the command...
Why did you consider this stale? It's only been open for two months. Were you expecting an earlier response?
There are a lot of ACPs and the queue is long. There are years-old ones still getting accepted. Example https://github.com/rust-lang/libs-team/issues/163
> directory from which the application loaded This is the directory in which the parent process executable resides, correct? Not the current working directory. I think the simplification you recommend...
I will add more examples when I get home (submitted this on my phone). If you read the comments, I called out explicitly whether `start_inclusive` should return by value. If...
> The new sample code doesn't work because if `start_inclusive()` returned by value it would need to consume `self`, making `self.end_inclusive()` failing to compile. For a return-by-value method you'll need...