Phil Pirozhkov

Results 721 comments of Phil Pirozhkov

Walking up the tree seems incorrect [here](https://github.com/rubocop/rubocop-rspec/blob/74d78371f4495099cf23bcf93b8af7ef711aec26/lib/rubocop/cop/rspec/unspecified_exception.rb#L65). I recall making a very similar note in another issue [here](https://github.com/rubocop/rubocop-rspec/issues/1949#issuecomment-2285070419), and the fix is the same. @rubocop/rubocop-rspec why do we have this...

Having spec_helper and rails_helper separate is a deliberate decision, but it’s not mandatory at all to always include the rails_helper I agree that requiring spec_helper is redundant and can be...

Sounds reasonable, as the [rspec-core’s project initializer](https://github.com/rspec/rspec-core/blob/main/lib/rspec/core/project_initializer/.rspec) does add `--require spec_helper` to `.rspec`.

Looks like a bug. > the result looks better than the original code Indeed, it’s subjectively harder to read after correction. > around blocks either shouldn’t be autocorrected Totally agree,...

We can remove that RSpec 4 job. It’s about to be released.

Fair enough. Seems that it’s failing because RSpec switched to having verified part doubles by default. It is puzzling howe build was passing as this has been in the build...

I’d argue that this style is significantly more frequently used and should be enforced. We strive for consistency. Is there a reason to bother projects/teams that used to the ternary...