Phil Pirozhkov

Results 731 comments of Phil Pirozhkov

This is really easy, as in either case you won’t have a o dig i to the abstract syntax tree or node patterns. Just write a spec for two cases,...

I suggest extending the spec in accordance with our findings. I'm happy to help on this front. Please accept my apologies for the delay in review, it's a summer season...

Sorry for the delayed response. We had a fruitful discussion in the ticket about what cop should and shouldn’t do. I recall it as: - it should not attempt to...

Thanks for reporting. If I remember correctly, the second argument, if a string, is not considered metadata. There’s however, no confirmation for this in the code docs https://github.com/rspec/rspec-core/blob/2ba0f10fe68948e5ee9addd569b4694f0245aa71/lib/rspec/core/example_group.rb#L205 But there’s...

This is the spec we’re after https://github.com/rspec/rspec-core/blob/2ba0f10fe68948e5ee9addd569b4694f0245aa71/spec/rspec/core/example_group_spec.rb#L636

There’s also [this PR](https://github.com/rspec/rspec-core/pull/2681). In the search, it mentions the “second docstring”, but I can’t quickly find it. Probably it’s in some collapsed comment thread or an older version of...

Here’s the interesting part https://github.com/rspec/rspec-core/pull/2681#discussion_r361811453 I think the takeaway here is that the second string argument works as an additional docstring. And will still be, for years to come. It...

Nice! A few practical examples to what you state above to help to dissect this: ### Example group with string metadata-wannabe: fail vs swallow ```ruby RSpec.describe "docstring", :real, "fake" do...

I'll also leave [this small reference](https://github.com/rspec/rspec-core/pull/2878) here just in case.