Phil Pirozhkov

> change the following document Maybe. I find it hard to understand what the “based” means in “dialect can be based on the following RSpec methods”, though. Can you think...

Thanks for reporting! The `unless rspec_method?(node)` seems incorrect. The spec didn’t catch that because it only [checked an RSpec basic method](https://github.com/rubocop/rubocop-rspec/blob/e02576f1a8c39d9dc5b3ca37fea4596f7e75f493/spec/rubocop/cop/rspec/dialect_spec.rb#L7). Would you like to send a PR to fix...

This cop should handle any source DEL without needing to configure it in the Language section. You just tell the cop to change background to describe, and that’s it. So...

`send #rspec? ...` is nearly a match-any pattern, as it would match any method call without a receiver. Since we already in an “on send” hook, this is mostly redundant....

I think the [inside_example_group?](https://github.com/rubocop/rubocop-rspec/blob/e02576f1a8c39d9dc5b3ca37fea4596f7e75f493/lib/rubocop/cop/rspec/mixin/inside_example_group.rb#L12) is fine because it returns true for the top-level example group like yours, and this will trigger for the top-level `background`, exactly what we need! Not...

~This can be closed~. The cop moved to another extension https://github.com/rubocop/rubocop-rspec_rails/pull/48

Fair enough! Actually, a cop targeting minitest would be be a better fit, as TimeHelpers are (to my best understanding) always included, and this means that it tears down automatically....

I’d check if we can avoid errors by using the obsoletion config. If removal of the option errors out, it should go to v4. But even if the above would...

So what happens if you add the following to .rubocop.yml? ``` RSpec/StringAsInstanceDoubleConstant: Enabled: false RSpec/VerifiedDoubleReference: EnforcedStyle: string ``` and run rubocop?

If we used the [changed_parameters](https://github.com/rubocop/rubocop/blob/566df8551b48ab98556ec42c005d66f1a23fad68/config/obsoletion.yml#L123), this would also result in an error, not a warning, right?