Phil Pirozhkov

Results 737 comments of Phil Pirozhkov

It would be quite hard to formalize, as the boundaries are blurry. Would ```ruby let(:user) do create(:user, ) end let(:another_user) { create(:user) } # nothing fancy ``` Why separate the...

Would you please harvest the real-world-rspec repo to see if one style prevails?

> If you use a method that mutates the constant, this mutation will be persisted across future tests Correct. > variables defined with `let` will be changed between contexts You...

It’s pretty [well documented](https://docs.rubocop.org/rubocop/usage/server.html#restart-server), but a surprising behaviour nevertheless.

@ydah The code looks good. As usual, I’d prefer to run new cops against real-world-rspec, as a preventive measure to user-reported errors. But if you lack capacity to do so,...

@ydah my apologies, this slipped my attention. Thanks a lot for the cop, it looks great!

We’ve been discussing this in #1189 and closed it as won’t fix. > this cop supports not only str but also dstr, it would be difficult to simply fix it...

It would fail on CI anyway, won’t it?

Should be easy to implement. Parts could be borrowed/extracted from the Focus cop, https://github.com/rubocop/rubocop-rspec/blob/7b930a0006eada6cdb6b381c0c441f5b6401dd69/lib/rubocop/cop/rspec/focus.rb#L71 A PR is welcome.

Would it make sense to configure this cop to only include feature/system spec paths. What do you think? > this cop should only look for given calls immediately inside of...