Phil Pirozhkov comments

Results 737 comments of


                                            Phil Pirozhkov

Raises exception instead of emitting warning.

@matthewrudy @pboling What are your thoughts on this guys?

Raises exception instead of emitting warning.

Ping.

Raises exception instead of emitting warning.

@matthewrudy what do you think of this change?

Raises exception instead of emitting warning.

Thanks, @pboling. Sad to hear that about Matthew. Unfortunately enough, I'm out of additional capacity ATM to maintain `memoist`.

Matchers missing compound methods

Good catch on `have_received`/`receive` not being composable. Reproduction example with the difference between non-composable and composable expectations: ```ruby RSpec.describe 'have_received' do class A def foo(x) end end subject(:a) { A.new...

Matchers missing compound methods

@eLod would you like to work on this improvement?

Matchers missing compound methods

@eLod incorrect message (`received :foo with unexpected arguments`) is for non-compound variant, so it's a problem that we already have. Compound expectation does not have this problem, and the failure...

Matchers missing compound methods

@eLod hm. Can you please push your work in progress? Let's figure it out together.

Revert "Temporarily disable rubocop 0.92 specs in CI"

Is this still needed?

Handle numblock in each cops

I haven't seen any issues with using `alias on_numblock on_block`, and there's even an InternalAffairs/NumblockHandler cop now. At least in rubocop-rspec we often disable the cop and skip aliasing, as...