rspec-style-guide
rspec-style-guide copied to clipboard
Empty lines around multi-line `let` and `let!` blocks
trafficstars
There is no information which style is preferred.
let :user do
build(:user, profile: profile).tap do |user|
user.save validate: false
end
end
let :user do
build(:user, profile: profile).tap do |user|
user.save validate: false
end
end
let :user do
build(:user, profile: profile).tap do |user|
user.save validate: false
end
end
or
let :user do
build(:user, profile: profile).tap do |user|
user.save validate: false
end
end
let :user do
build(:user, profile: profile).tap do |user|
user.save validate: false
end
end
let :user do
build(:user, profile: profile).tap do |user|
user.save validate: false
end
end
It would be quite hard to formalize, as the boundaries are blurry.
Would
let(:user) do
create(:user, <a lot of attributes that forced the author to use the multi-line syntax because of the max line length limitation>)
end
let(:another_user) { create(:user) } # nothing fancy
Why separate the two?
And on the other hand,
let(:user) { create(:user) }
# the line above intentionally left blank as it separates unrelated setup
let(:multiplier) { 3 }
let(:divisor) { 5 }
Would you want to have this applied to all multiline blocks? If so, see https://github.com/rubocop/ruby-style-guide/issues/823