Phil Pirozhkov
Phil Pirozhkov
Rebased and green @bquorning @Darhazer
Thank you for the contribution and your time, @akrox58 !
Good catch! This `create` runs even before `before(:suite)` hooks. Few things to consider: - calls without assignment to variables - `fabrication` gem - model class `create!` calls (can this be...
I'd start with the second one as more impactful. Also, I remember that variables can be quite handy in some cases, e.g.: ``` describe SomeConcern do klazz = Class.new do...
One example of a legitimate usage of a variable https://github.com/rubocop-hq/rubocop/pull/8447#discussion_r467528726 > inefficient since it gets defined every test example. Is that the reason No, just because variables are simpler.
Sounds great @thijsnado 👍
@thijsnado No worries, there's a fix https://github.com/rubocop-hq/rubocop-rspec/pull/1014 It's caused by https://github.com/rubocop-hq/rubocop/issues/8561
It makes sense to open this issue on https://github.com/reachlocal/rspec-style-guide or https://github.com/lelylan/betterspecs, we're just soldiers here, we don't create rules.
I was actually thinking of adding a `when`/`with` and `without` helpers, e.g.: ``` describe '...' do when 'the visitor has an email' do with 'a corresponding user' do without 'a...
Related to #757. [Context Descriptions guideline](https://rspec.rubystyle.guide/#context-descriptions) is now more permissive: > When an example block description is composed with context block descriptions, it should result in a sentence with proper...