Phil Pirozhkov

Results 699 comments of Phil Pirozhkov

Sounds reasonable. Would you like to hack on it?

Thanks for the contribution. It might be a good idea to implement a more generic cop that would enforce the order of elements inside an example group. Something to look...

Do you mind turning on "allow edits from maintainers"? I can push the fix for config validation. Or feel free to commit this patch: ``` From 6e2c9b6395ab9532dce36a112d280cdb40ac496e Mon Sep 17...

> I might shelf this PR and put some time into a Layout/SpecStructure? That would be great! I mean, this cop is still good, but if you're up for a...

I still can't push to your branch for some reason. `rake generate_cops_documentation` is all that's needed to fix the build.

To make the CI green: ![image](https://user-images.githubusercontent.com/6916/131560321-5c895d0c-7968-4deb-98fd-10ab0b992e44.png) For some weird reason, I still can't push.

> get this one in so my team can start using it, and in the meantime will work on the SpecLayout PR Makes perfect sense 👍

Now, when I think about this cop, which basically suggests putting `let`s before `subject`. ```ruby # good let(:params) { blah } subject { described_class.new(params) } ``` The cop goes against...

It makes sense to synchronize the 3.0 release with the RuboCop 2.0 release. I was believing that RuboCop planned major releases every year. For the reason of not forcing users...

If you consider a pair to be a list of two records, it's not necessary to rename the cop. > How do I inform RuboCop about a renamed cop? Example:...