Phil Pirozhkov

Results 694 comments of Phil Pirozhkov
trafficstars

To sum this up, what's left: 1. `Layout/IndentationConsistency` -> ~`Layout/MethodIndentation`~ `Layout/InconsistentIndentation`. 2. `Lint/PercentStringArray`: This cop checks for quotes and commas in %w, e.g. `%w('foo', "bar")` I'd go with `Lint/RedundantPercentWPunctuation`, or...

@scottmatthewman Would you like to cover this last mile yourself, or do you need a hand with that?

It would allow removing those tweaks from extensions: [`rubocop-rspec`](https://github.com/rubocop/rubocop-rspec/blob/cf272285131d2296c91b20f3ae2ce239cf4c0c7e/config/default.yml#L115), [`rubocop-rails`](https://github.com/rubocop/rubocop-rails/blob/3a937065ca8e63e97c5cbb408cafd6ab3d4e0db2/config/default.yml#L3).

> I experimented with letting Includes be merged as well, but that's a much bigger change since default configuration uses Include to let specific cops only inspect one kind of...

@zofrex There's [not much logic](https://github.com/rubocop-hq/rubocop/pull/7567/files#diff-a3b8009f2831797a20b82c0691debf68789be59f13723886fbd07058a6ddcaa8R252) in how Pending cops are treated. If you happen to run in a situation where you would feel that extracting some parts would worth it...

Briefly skimmed through comments, and I think we've agreed that the approach with setting the version separately for extensions (and core) is the only choice. I have no awareness of...

`RangeHelp` is [now](https://github.com/rubocop/rubocop/pull/10748) pretty consistent. We may eventually want to deprecate the old kwarg, but it's not for 2.0. Should we keep this to remember of would willingness to deprecate...

Can we consider this done?