Phil Pirozhkov

Results 668 comments of Phil Pirozhkov

I completely agree about your point of consistency in the scope of a given project. There's this note in the Ruby style guide: > There are some areas in which...

On a different note, there clearly seems to be no single way of doing things. > Ask a hundred developers how to test an application, and you’ll get a hundred...

Alternatively, RSpec's [`spec_helper.rb` template](https://github.com/rspec/rspec-core/blob/7b6b9c3f2e2878213f97d6fc9e9eb23c323cfe1c/lib/rspec/core/project_initializer/spec/spec_helper.rb#L88) can also be used as a reference. > Run specs in random order to surface order dependencies. If you find an order dependency and want to...

Basically because "should" syntax is being removed from RSpec, along with all references to it. See https://github.com/rspec/rspec-core/pull/2864/files#diff-8c60417422cf21f6d3abdc5b63d992eee058c43039601cc0cee1d7111db85420L1133

Practical example https://github.com/rubocop-hq/rubocop-rspec/issues/748#issuecomment-491103435

Is this specific to `rspec-rails`, or does bare RSpec require support files? I see this in [RSpec's own test suite](https://github.com/rspec/rspec-core/blob/7b6b9c3f2e2878213f97d6fc9e9eb23c323cfe1c/spec/spec_helper.rb#L3): ``` require 'rspec/support/spec' ```

There's also [`when_first_matching_example_defined`](https://relishapp.com/rspec/rspec-core/v/3-8/docs/hooks/when-first-matching-example-defined-hook): ``` RSpec.configure do |config| config.when_first_matching_example_defined(:db) do require "support/db" end end ``` Together with [`define_derived_metadata`](https://github.com/rspec/rspec-core/pull/1496/files#diff-347a1d9242143ec7d337efe37081249aR1224): ``` RSpec.configure do |config| # Tag all groups and examples in the spec/model...

`on_potential_false_positives` with `:raise` is awesome 👍

It is very reasonable to use `.lint`, especially with `traits: true`. Very well worth it. This, however, doesn't work in certain situations, still, workarounds exist. 1. "Abstract" factories Disclaimer: [abstract...

I believe your example @RobinDaugherty falls into a category of specs that have a compelling benefit, while the one from description doesn't yet. There's [yet another recommendation](https://github.com/rubocop-hq/rspec-style-guide/issues/70) that is mentioned...