Matthew Zipkin
Matthew Zipkin
Looking for reviewers for this PR: https://github.com/bcoin-org/bcoin/pull/1038 This isnt full taproot validation, just bech32m support so bcoin can send BTC to Taproot addresses after activation.
Yes, but it's also accepted relay policy on 99% of network nodes. Unless they are accepting 0-conf transactions as final, I'm not sure why any user would reject RBF from...
That's a good idea as well, although personally I've had issues with wallets (BRD, on iPhone) spending unconfirmed change outputs during the 2017 "fee event" leaving me with a long...
In addition, I believe the version check here should be removed. Bitcoin Core does not take transaction version into account when determining opt-in RBF. The only thing that matters is...
> Even if a transaction's `sequence < 0xfffffffd` , RBF will be allowed. Well what it means is that even TX with `version === 1` will be considered opt-in RBF...
Also want to call attention to this: https://github.com/bcoin-org/bcoin/blob/7b47913f3c92cc661c9bcf3af6ab619db46e551e/lib/primitives/tx.js#L966-L969 This is NOT a protocol rule. TX version 2 is defined by [BIP 112](https://github.com/bitcoin/bips/blob/master/bip-0112.mediawiki) (OP_CSV) to add new functionality to the `nSequence`...
Rebased on master. I think this has been a useful branch to maintain for some users even if it doesn't get merged. BIP49 nested-segwit wallets were the default on Trezor...
Rebased on master again, to include client inside repo. Also added `purpose` to options available when creating a wallet from client, including `bwallet-cli` .
I'm not sure this is totally necessary. A "reorg" isn't _really_ a thing anyway: what happens is blocks are disconnected and (re-)connected. bcoin's internal indexer operates on these events: https://github.com/bcoin-org/bcoin/blob/3bb66913ee00c796b90052cbeea4e0d546669a06/lib/indexer/indexer.js#L211-L214...
bcoin ports are discussed on https://bcoin.io/api-docs and https://github.com/bcoin-org/bcoin/blob/master/docs/Configuration.md, even Bitcoin Core uses port `8332` for RPC commands -- how do you think we should address this better? Better docs? Or...