Matthew Zipkin
Matthew Zipkin
Another big thing we should look at is, instead of modifying `filterindexer` -- we should use that as a base class and instantiate multiple indexers for different filter types. That's...
It also might be good to add a new test file like `filter-test.js` which instantiates a full node with multiple filter indexers and tests them both for consistency. It might...
We can also add filter indexer here! https://github.com/bcoin-org/bcoin/blob/f8118d0d9aef493b1ec93ccf026eaf863c9e7056/lib/indexer/index.js#L13-L15
this might need to be `options.location`?? https://github.com/bcoin-org/bcoin/blob/f8118d0d9aef493b1ec93ccf026eaf863c9e7056/lib/indexer/indexer.js#L155 ``` --> bcoin --prefix ~/Desktop/filter-test --index-filter [info] (blockstore) Opening FileBlockStore... [info] (chain) Chain is loading. [info] (chain) Checkpoints are enabled. [info] (chaindb) Opening...
TODO: MIGRATION
todo: ` await this.db.verify(layout.V.encode(), 'index', 1); `
✅ Tested `_index` method by deleting index folders and restarting bcoin 🤔 Tested migration script by synching 100000 blocks with bcoin v2.2.0 then upgrading, some issues: 1. We must enforce...
Ok I went through everything again and it so SO good. Really great work and alot of hard work here! SO thankyou and congratulations, we're almost there. I think there's...
Importing the discussion from the issue: > Okay so #960 should resolve the issue for new synchronizations. > > To fix existing synchronizations there could be: > > A manual...
Update looks good, utACK for now @ 0a82ad9ea175a3a30309db2a1686a2d0c64d0d4c