Matthew Zipkin

Results 713 comments of Matthew Zipkin

I think I'm coming around on this one, it allows for some interesting applications that connect to hsd (or even a browser-based spv node) without having to rely on DNS...

Hmmmm... ASM stands for "assembly" and should refer exclusively to opcode UTXO script in my opinion. Don't really love the concatenated string look either... Almost none of the covenant items...

Ha, yeah I was just thinking a flag for getJSON as well - because what we really want is two versions of the same thing (`items` object returned as machine-readable...

fromASM() would just be a wrapper around / prettier version of this? ```js const redeem = new this.Script(); redeem.pushSym('OP_IF'); redeem.pushSym('OP_SHA256'); redeem.pushData(hash); redeem.pushSym('OP_EQUALVERIFY'); redeem.pushData(swapPubkey); redeem.pushSym('OP_CHECKSIG'); redeem.pushSym('OP_ELSE'); redeem.pushInt(locktime); redeem.pushSym('OP_CHECKSEQUENCEVERIFY'); redeem.pushSym('OP_DROP'); redeem.pushData(refundPubkey); redeem.pushSym('OP_CHECKSIG');...

See https://github.com/bcoin-org/bcoin/pull/605 -- this rpc call is already problematic for two reasons: 1. It's not paginated, so a wallet with a huge history is going to timeout anyway 2. Transactions...

Be sure to check out bcoin #605, Braydon wrote pagination stuff already, it just never got reviewed or merged.

@kilpatty should we close this and work on a deeper fix instead?

Ok cool, up to you on which branch you push to :-)

Following up on this a bit... the `force` param is consumed in some downstream functions to bypass the database locks: https://github.com/handshake-org/hsd/blob/505b6f76834ef93ee883b8052780936c92f199fa/lib/wallet/wallet.js#L1134-L1141 But we still aren't actually using the argument to...

@protovist no one is mining on testnet and the lack of blocks is causing network errors.