Matthew Zipkin

@chikeichan finally getting to more deeply review this. I'm playing with the test locally, converting it more hsd-friendly parameters etc. Looks like the main patch isn't just Braydon's commit but...

So I think `txid` is correct and should not be changed. The issue is what `hash` means. In Handshake, all TX are witness tx, so if we follow Bitcoin semantics...

So I think what may need to change is this in TX.js: https://github.com/handshake-org/hsd/blob/1da031c1ce3522ef40f2c2ea1ff60cfe70b30ff9/lib/primitives/tx.js#L1693-L1694 it should probably be: ``` txid: this.txid(), hash: this.wtxid(), ```

> Both the SIG0 key and the brontide key returned for a DNS request to the Handshake root . for the resource record type KEY (SIG0 specifies that in its...

I thought the `key` used to zone-sign and key-sign was from the hard-coded file https://github.com/handshake-org/hsd/blob/155051f7f9af115dc2b8a7bef90963e54e87c5ed/lib/dns/key.js ?

@james-stevens thanks for all the great insight, I'd love to chat with you on #handshake on freenode about some of these details sometime. I'll try to address a few of...

Concept ACK but I think we should cover all the tests before merge: `auction-reorg-test.js` I think may be the only other test that needs updates. Seems to have this in...

> I am wondering if we should modify this and/or add `getbalancedetails`(or `info`) rpc methods to include balance details which can be used by users however they want. It could...

h/t @turbomaze for posting some covenant spec details: https://github.com/namebasehq/handshake-types

There is also a `/fee` endpoint in `lib/node/http.js` that should be addressed. Note the HTTP module has a RESTful API endpoint like you'd expect: https://github.com/handshake-org/hsd/blob/155051f7f9af115dc2b8a7bef90963e54e87c5ed/lib/node/http.js#L408 But ALSO has a websocket...