hsd icon indicating copy to clipboard operation
hsd copied to clipboard

Published 20 hours ago • verified publisher icon handshake-org

Argument 'force' is unused in `wallet.makeOpen()`, others...

Open pinheadmz opened this issue 6 years ago • 1 comments

https://github.com/handshake-org/hsd/blob/master/lib/wallet/wallet.js#L1493

I see this param force get passed around in wallet, and checked typeof force === 'boolean' but never really used? Am I missing something or is this for an old or future feature?

pinheadmz avatar Jan 25 '19 22:01 pinheadmz

Following up on this a bit... the force param is consumed in some downstream functions to bypass the database locks:

https://github.com/handshake-org/hsd/blob/505b6f76834ef93ee883b8052780936c92f199fa/lib/wallet/wallet.js#L1134-L1141

But we still aren't actually using the argument to makeOpen this way.

pinheadmz avatar Aug 25 '21 15:08 pinheadmz