Pierre Jeambrun
Pierre Jeambrun
This sounds like a nice improvement :) I had a similar issue one time and we tried generating random colors based on the tag values. Sort of a hash function...
> code looks fine but it's nice to include a screenshot of the visual change You are right. I didn't change much so I didn't bother, but here is a...
> I like your approach of splitting it into 2 tables more. When you rebase your branch. Let's keep that. Ok, i did that and updated the titles so we...
Hello @josh-fell, For display purpose I think none of them should have the group_id prefix. (We already have it in the surrounding element). I think the graph is drawn with...
I updated the PR and the description. - Nav link is done, and removed them from the table, nice suggestion. :) I'm not sure about direct log access, I feel...
> Since we store the map_index in the url, we need to make sure we load an individual mapped task instance details. Try refreshing the page when you have a...
Maybe this is the source of some of the confusion. (I checked auto refresh for mapped task and tasks without logs, it's working now).
> I don't think we should be using `useEffect` here. The Details component should probably get the mapped instance info from the API: `/dags/{dag_id}/dagRuns/{dag_run_id}/taskInstances/{task_id}/{map_index}` Good idea that would indeed simplify...
With your suggestions I was able to come up with a much simpler implementation, that I feel will be more robust as well. Thanks
Thank you Brent :)