airflow icon indicating copy to clipboard operation
airflow copied to clipboard

Published 20 hours ago • verified publisher icon apache

Grid, fix 404 taskInstance errors

Open pierrejeambrun opened this issue 2 years ago • 2 comments

~~We had a few warnings due to validateDOMNesting in the grid view (cf screenshot) -> split the table into two distinct tables with separate 'titles'. Took the opportunity to slightly improve spacing between the tables.~~ (fixed in https://github.com/apache/airflow/pull/26551) image image

We also had a few 404 errors when requesting the useTaskInstance for groups, by clicking on the details of a task group. (cf screenshot): image

pierrejeambrun avatar Sep 21 '22 20:09 pierrejeambrun

code looks fine but it's nice to include a screenshot of the visual change

You are right. I didn't change much so I didn't bother, but here is a preview: image

edited: @bbovenzi already fixed the dom warnings https://github.com/apache/airflow/pull/26551, I'll edit this PR to just fixe the 404 errors.

pierrejeambrun avatar Sep 22 '22 07:09 pierrejeambrun

I like your approach of splitting it into 2 tables more. When you rebase your branch. Let's keep that.

bbovenzi avatar Sep 22 '22 12:09 bbovenzi

I like your approach of splitting it into 2 tables more. When you rebase your branch. Let's keep that.

Ok, i did that and updated the titles so we have something consistent with the 'Task Actions' title: image

pierrejeambrun avatar Sep 22 '22 15:09 pierrejeambrun

nice, thanks, yeah i knew the formatting was off but could not figure out what was wrong ... this looks great...

dstandish avatar Sep 22 '22 18:09 dstandish