Pierre-Alexandre Meyer

Results 95 comments of Pierre-Alexandre Meyer

No, we only search on one key. See https://github.com/killbill/killbill-commons/blob/master/queue/src/main/resources/org/killbill/notificationq/dao/NotificationSqlDao.sql.stg#L31 and https://github.com/killbill/killbill-commons/blob/dc64043e28e4fcaaec93508b369c6e8df1281a93/queue/src/main/java/org/killbill/notificationq/DefaultNotificationQueue.java#L102.

[We talked about it IRL, but just for the records] > Still confused why we would need it though (for Kill Bill): Once we specify searching by account_record_id, it will...

We should just double check we've updated Kill Bill to use it (see my comment about security issue above).

While I don't fully understand the issue, https://github.com/killbill/killbill-commons/pull/70 most likely works around it (get + claim done in one transaction). Will close after verifying we don't see these anymore in...

Some thoughts: > Deleted plugin is still declared in the kpm.yml file IMHO `kpm install` should be idempotent, hence cleanup and fix discrepancies (i.e. re-install the plugin, cleaning up identifiers...

To add more details: `ServiceDiscoveryRegistry` is currently only (optionally) provided by the [Eureka](https://github.com/Netflix/eureka) Kill Bill [OSGI bundle](https://github.com/killbill/killbill-platform/tree/work-for-release-0.23.x/osgi-bundles/bundles/eureka). Manual testing is required after the above change by installing the bundle and...

We use Jooby in a lot of our [Kill Bill](https://killbill.io) plugins. Awesome framework!

> this leads to an unusable generated client Which language are you trying to generate? For nearly all of the officially supported languages, we had to tweak the generator (e.g....

> Well, I'm generating an elixir client, but that's not the point of my issue. What I was trying to say was that you should expect to have to modify...