Pierre-Alexandre Meyer
Pierre-Alexandre Meyer
Should we address this [TODO](https://github.com/killbill/killbill/pull/1597/files#diff-d841db8edf5d8f41574f4ed0353e2b124833bf69eae6fbc8811105fadd6db883R129), i.e. introducing a config for this, and commit the fix?
Yes, I think that's a good idea. We should document this behavior and explain how to switch the delimiter, instead of trying to fix the code.
A first attempt on master: https://github.com/killbill/killbill/pull/1574/files Some of the patch above (e.g. test) can likely be reused when working on this ticket.
Note that we now support per-plugin payment state machines, so the UI could be driven by the specific configuration of the plugin associated with the payment.
While it's now easy to get access to the plugin state machine, we only have access to the raw XML in Kaui. We would need a lot of logic on...
This should be fixed in the templates instead.
Most of the code is auto-generated (see https://github.com/killbill/killbill-client-php/blob/master/README.md#api-generation). These changes would be overridden next time we re-generate the client, unless the template files reflect this fix. I also suspect other...
FWIW We did some work to support M1 last year (https://github.com/killbill/killbill-cloud/pull/217). It was only tested by the community though, as none of us have one 😞
Difference between catalogs: ``` --- Insurance-v1.xml 2023-05-19 10:23:12 +++ Insurance-v2.xml 2023-05-19 10:23:16 @@ -17,7 +17,7 @@ - 2022-05-18T00:00:00+00:00 + 2023-05-18T00:00:00+00:00 Insurance IN_ADVANCE @@ -70,6 +70,7 @@ + 2023-05-18T00:00:00+00:00 Liability @@...
It looks like there are two different issues (maybe related though). 1. SQL error in the method `getByBlockingIds`: ``` 2023-06-02T12:03:15,246+0000 lvl='WARN', log='EntitySqlDaoWrapperInvocationHandler', th='catalina-exec-64', xff='174.172.176.135,10.208.69.152', rId='', tok='', aRId='37360', tRId='1', Error during...