Steve Pieper

Results 541 comments of Steve Pieper
trafficstars

Thanks for your comments @lassoan but I will take issue with your conclusions. Restarting after unloading a module *may* be required, but I don't see any reason to assume that...

Yes, this strikes me as a bit odd - with this patch if I turn of segmentation support I'll still build classes like Libs/MRML/Widgets/qMRMLSegmentSelectorWidget.cxx but with methods like void qMRMLSegmentSelectorWidget::setSelectedSegmentIDs(QStringList...

I had started looking at this. Best would be to improve the [python dicomweb-client](https://dicomweb-client.readthedocs.io/en/latest/introduction.html) code to use an [asyncio](https://docs.python.org/3/library/asyncio.html) [version of requests](https://pypi.org/project/aiohttp-requests/). But to use that in Slicer, we need...

Agreed. There's not a lot of code required to implement the dicomweb part. I think we could even imagine refactoring ctkDICOMDatabase to have either an sqlite or dicomweb backend. Or...

It would be good to have an interface to work with multiple dicom resources, local and remote. The interface should be consistent so you don't need completely different codebases like...

There's really no change on this. The [python dicomweb_client](https://dicomweb-client.readthedocs.io/en/latest/introduction.html) code is still synchronous, so the app blocks and there are no overlapped network requests so performance is pretty bad. There's...

I think simpler is better for the default. We're often guilty of offering too many buttons and these are particularly off-putting to me because of the error and warning icons....

> > too many buttons and these are particularly off-putting to me because of the error and warning icons. > > Can you explain more about this point? Yes, my...

> > the row of buttons looks too much like they are indicators of actual errors and warnings instead of filter modes. > > Would it be better if the...

The checkboxes really clarify the intent to me, thanks for playing with that. I agree that including the icons is nice. Could they be made smaller? That would save space...