Steve Pieper

Results 541 comments of Steve Pieper
trafficstars

> > I think creating a segmentation with no actual pixel data would be incorrect. > > I fully agree. I would think creating an empty segmentation is perfectly valid,...

@fedorov it sounds like you are concerned about current OHIF not having features to make it clear that segmentations are empty, and that's a fair issue. But I agree with...

My $0.02 - highdicom should provide a set of SOPClass-aware utilities that allow sorting of frames in ways that may be useful to the consumer of multiframe instances. I'd want...

> However, this approach would not solve the interoperability issues with existing applications. But ultimately, they should be fixed anyways if they claim compliance.. Very true - my thought would...

It can be helpful for the user to provide a sorter, but it's also likely that the pattern can be deduced from the content/context of the multiple frames of the...

Yes, I think handling network/server failures should be outside the core dicomweb logic. Being able to pass in a `retry` decorator instead of a `retrying` one would have been nice...

@hackermd I like the suggestion from @ntenenz that the retry logic should be outside of the library itself, or to avoid breaking changes we keep your current minimal implementation without...

No, I didn't see the event hooks. Not sure that would have been exactly on point for my needs without more work though since I wanted to just know what...

> Are there any other use cases beyond retrying where it would be useful to pass custom decorators for these functions? Logging and retries are the two obvious ones. Related...

Yes, now that we have a good plan I can try that out next time I do a dive into that use case. Now that I know what the core...