Ivan Tham

Results 389 comments of Ivan Tham

@connorskees Are we aiming to be incremental later on such that we need salsa instead of building using our own graph system?

Yes, that's the one used in dart-sass, I saw that they have `ImportCache`. Besides, I wonder if switching to async would give benefit for us for parallel compilation.

> libsass is currently in the early stages of being deprecated. I will be interested to see what the outcome of that process means for grass. Heh, we could add...

rsass have different aims, `grass` aims not to use any parser libraries but `rsass` uses `nom`.

`dart-sass` keeps all of them https://github.com/sass/dart-sass/blob/6565b45a6ce17380839af3ce166365595a1fbdc9/lib/src/value/color.dart#L16-L56 but I believe we can calculate it lazily without storing it. `libsass` on the other hand only store rgba for rgba color and hsla...

@ztombol Yeah, if it is parallel, it will possibly benefict those computer that have a lot of processer. Well, most of the things I did in my scripts are parallel,...

@ztombol, I am actually not very sure about how to start it just only by bash. I actually do parallelism using Makefile, well it is not the best choice, I...

Probably we could use something like http://stackoverflow.com/questions/5547787/running-shell-script-in-parallel/5547845#5547845 with the help of `-j` so that it can run parallelly, I don't have time to implement this right now, should I close...

The last match `pattern[p]` can use `c` instead of `_` and not having to repeat `pattern[p]`.

If you don't have to convert the logic, can also just use pattern matching instead of multiple conditionals, it could be easier to understand. ```rust fn glob(pattern: &[u8], text: &[u8])...