Ivan Tham

Results 525 comments of Ivan Tham

cc @kdy1 who may be interested for https://github.com/swc-project/swc/pull/950

@connorskees I think compressed output is not as good as the original one yet. There are quite some optimizations that we could do. Also, I think we can do better...

I also added directory support. But without a graph for caching, out speed is still quite fast. ``` > time /usr/bin/sass bootstrap/scss/:/tmp/bootstrap ________________________________________________________ Executed in 445.37 millis fish external usr...

No, very likely because we process 4 input files (entry points) without caching, dart-sass have cache but we need to process each dependency again, so if each file use the...

I am not quite sure how the original `:` works (looks complicated), there are quite a lot of different types of input accepted by dart-sass, not sure if we want...

@connorskees What's next on this?

Ping @connorskees I would say even after this patch it is not good yet, the way the original dart-sass does take it a variety of input format, I don't quite...

> If there is only 1 compilation, why does caching play into this? I am still very confused as to the role caching plays in all of this. What are...

> Could we do is_scss_or_sass? It's only a few characters longer but it should make its purpose much clearer. > > The implementation could likely be simplified to s.ends_with(".sass") ||...

Currently you can configure that using `Options::load_path` but that still requires separate file, most likely can be done using separate file. We might need to have another file resolver if...