Ivan Tham

Results 389 comments of Ivan Tham

I am interested in caesar cipher.

@AnshulMalik I have added the caesar cipher https://github.com/TheAlgorithms/Rust/pull/55

@ayaankhan98 If no one is currently maintaining it, I can help to temporary maintain the repo to reduce the amount of open pull requests and help to review them at...

@nabijaczleweli Nice, thanks for the comment, I will try my best to make it simpler. Let me start with `rustup override`. Here, we can: - `rustup override list` which list...

@jplatte I just changed it to use `matches!(`.

Regarding correctness, I just saw that but I think that having the patch is way more correct than not. Not having it entirely breaks chinese characters with `-` in between...

> I think I'd be okay merging this if I could verify easily enough that these unicode ranges are in fact for blocks where you would otherwise get splits between...

> I don't care so much about the list being exhaustive (that was not what I was talking about), but there has to be some way to verify the ranges...

> Well, how did you come up with these ranges? I checked out other implementations and see the different ranges in wikipedia. > That would presumably include ranges for things...

> If there is one / many Wikipedia pages where one can easily correlate these scripts with their unicode ranges and verify they are in fact continuous scripts, could you...