Marc Pichler

Results 428 comments of Marc Pichler

@seongpil0948 sorry for the late reply - are you still interested in working on this?

With the changes from #2259 it is possible to add the package here in this repo as a [vendor component.](https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/CONTRIBUTING.md#contributing-vendor-components) Keep in mind though: with the future developments that I...

cc @david-luna @trentm (owners)

Hi @dudo, thanks for reaching out - I think you also need to add the instrumentation hook for ESM (see "Startup command for ESM"): https://github.com/open-telemetry/opentelemetry-js/blob/main/doc/esm-support.md#using-the-zero-code-option-with-auto-instrumentations-node

Apologies, this fell of my radar. Looking into it again now. > Hello, [@pichlermarc](https://github.com/pichlermarc)! That is super helpful, thank you! I was coming from the auto instrumentation library docs, and...

Hmm, I did try to reproduce this but was unable to (unfortunately, unless a example is really minimal I cannot run it - I need to be absolutely sure what's...

Yep, resource attributes should not go onto a span, that's correct. I think that might be incorrect in the current implementation [here](https://github.com/open-telemetry/opentelemetry-js-contrib/blob/162feb11f7fc4715675e0b566aa5cf30028fb39f/plugins/node/opentelemetry-instrumentation-aws-lambda/src/instrumentation.ts#L239).

> Hi @pkanal - FYI, we require two component owners (members of the org) that are responsible for PR reviews and issue triage sign up in `.github/component-owners.yml` before merging any...

Looks good % package-lock conflicts. 🙂 Re-requesting a review from @martinkuba as it's still marked as `Changes Requested`

This PR needs approval from the owner of the instrumentation, cc @d4nyll - having it in the auto-instrumentation package and enabled by default will likely mean more users, which means...