opentelemetry-js-contrib icon indicating copy to clipboard operation
opentelemetry-js-contrib copied to clipboard

feat(auto-instrumentations-node): enable runtime-node

Open romancepenguin opened this issue 1 year ago • 6 comments

Which problem is this PR solving?

  • I want to use gc and heap metric functions with auto-instrumentations-node.
  • merge below, so I just need to work on a few lines.
  • https://github.com/open-telemetry/opentelemetry-js-contrib/pull/2136

Short description of the changes

  • This PR adds @opentelemetry/instrumentation-runtime-node to the @opentelemetry/auto-instrumentations-node meta package

romancepenguin avatar Nov 11 '24 09:11 romancepenguin

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: romancepenguin / name: leejaekyu (d0136556446d01d69d014c86e5c60874a1e887fc)

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.75%. Comparing base (5eb61d8) to head (d013655). Report is 134 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2524   +/-   ##
=======================================
  Coverage   90.75%   90.75%           
=======================================
  Files         169      169           
  Lines        8018     8019    +1     
  Branches     1632     1632           
=======================================
+ Hits         7277     7278    +1     
  Misses        741      741           
Files with missing lines Coverage Δ
...tapackages/auto-instrumentations-node/src/utils.ts 98.24% <100.00%> (+0.01%) :arrow_up:
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 21 '24 19:11 codecov[bot]

Hi, would be good to have this merged and released. Thank you

ElfoLiNk avatar Dec 18 '24 11:12 ElfoLiNk

This PR needs approval from the owner of the instrumentation, cc @d4nyll - having it in the auto-instrumentation package and enabled by default will likely mean more users, which means often means that additional maintenance effort is required.

pichlermarc avatar Jan 15 '25 11:01 pichlermarc

@pichlermarc Happy to handle any additional maintenance work

d4nyll avatar Jan 15 '25 17:01 d4nyll

@romancepenguin please resolve the conflicts, then we can merge this in 🙂

pichlermarc avatar Feb 13 '25 10:02 pichlermarc

Hi @romancepenguin any news?

ElfoLiNk avatar Mar 26 '25 20:03 ElfoLiNk

Solved by #2786

maryliag avatar Apr 14 '25 12:04 maryliag