phsft-bot

@CERN Geneva, Switzerland

Results 2266 comments of


                                            phsft-bot

trafficstars

[tree] Add missing `override` specifiers in tree/dataframe

Starting build on `ROOT-debian10-i386`/`soversion`, `ROOT-performance-centos8-multicore`/`cxx17`, `ROOT-ubuntu18.04`/`nortcxxmod`, `ROOT-ubuntu2004`/`python3`, `mac1015`/`cxx17`, `mac11`/`cxx14`, `windows10`/`cxx14` [How to customize builds](https://github.com/phsft-bot/build-configuration/blob/master/README.md)

[tree] Add missing `override` specifiers in tree/dataframe

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build [See console output](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/156147/console). ### Errors: - [2022-10-03T12:16:06.721Z] FAILED: lib/modules.idx

[tree] Add missing `override` specifiers in tree/dataframe

Build failed on ROOT-ubuntu18.04/nortcxxmod. Running on sft-ubuntu-1804-2.cern.ch:/build/workspace/root-pullrequests-build [See console output](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/156146/console). ### Failing tests: - [projectroot.roottest.cling.array.roottest_cling_array_runarray1](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/156146/testReport/projectroot.roottest.cling/array/roottest_cling_array_runarray1/) - [projectroot.roottest.cling.autoauto.roottest_cling_autoauto_ROOT8442](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/156146/testReport/projectroot.roottest.cling/autoauto/roottest_cling_autoauto_ROOT8442/) - [projectroot.roottest.cling.autoauto.roottest_cling_autoauto_assertROOT8445_auto](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/156146/testReport/projectroot.roottest.cling/autoauto/roottest_cling_autoauto_assertROOT8445_auto/) - [projectroot.roottest.cling.bytecode.roottest_cling_bytecode_runcomplex](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/156146/testReport/projectroot.roottest.cling/bytecode/roottest_cling_bytecode_runcomplex/) - [projectroot.roottest.cling.bytecode.roottest_cling_bytecode_runhenry](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/156146/testReport/projectroot.roottest.cling/bytecode/roottest_cling_bytecode_runhenry/) - [projectroot.roottest.cling.const.roottest_cling_const_run1](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/156146/testReport/projectroot.roottest.cling/const/roottest_cling_const_run1/) - [projectroot.roottest.cling.const.roottest_cling_const_run2](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/156146/testReport/projectroot.roottest.cling/const/roottest_cling_const_run2/) - [projectroot.roottest.cling.controls.roottest_cling_controls_runLoopbreak](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/156146/testReport/projectroot.roottest.cling/controls/roottest_cling_controls_runLoopbreak/) -...

[tree] Add missing `override` specifiers in tree/dataframe

Build failed on windows10/cxx14. Running on null:C:\build\workspace\root-pullrequests-build [See console output](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/156150/console). ### Failing tests: - [projectroot.roottest.root.meta.MakeProject.roottest_root_meta_MakeProject_stl_makeproject_test_build](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/156150/testReport/projectroot.roottest.root.meta/MakeProject/roottest_root_meta_MakeProject_stl_makeproject_test_build/) - [projectroot.roottest.root.meta.MakeProject.roottest_root_meta_MakeProject_stltest2](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/156150/testReport/projectroot.roottest.root.meta/MakeProject/roottest_root_meta_MakeProject_stltest2/) - [projectroot.roottest.root.meta.MakeProject.roottest_root_meta_MakeProject_examples](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/156150/testReport/projectroot.roottest.root.meta/MakeProject/roottest_root_meta_MakeProject_examples/) - [projectroot.roottest.root.meta.MakeProject.roottest_root_meta_MakeProject_stltest](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/156150/testReport/projectroot.roottest.root.meta/MakeProject/roottest_root_meta_MakeProject_stltest/)

[tree] Add missing `override` specifiers in tree/dataframe

Build failed on mac1015/cxx17. Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build [See console output](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/156148/console). ### Failing tests: - [projectroot.gui.webdisplay.test.test_webgui_ping](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/156148/testReport/projectroot.gui.webdisplay/test/test_webgui_ping/) - [projectroot.roottest.python.distrdf.common.roottest_python_distrdf_common_test_all](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/156148/testReport/projectroot.roottest.python.distrdf/common/roottest_python_distrdf_common_test_all/)

Enhance support of cling cmd prompt func defining

Can one of the admins verify this patch?

[cmake] always check if `json_fwd.hpp` header provided

Build failed on mac1015/cxx17. Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build [See console output](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/152959/console). ### Failing tests: - [projectroot.gui.webdisplay.test.test_webgui_ping](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/152959/testReport/projectroot.gui.webdisplay/test/test_webgui_ping/) - [projectroot.roottest.python.distrdf.dask.roottest_python_distrdf_dask_test_all](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/152959/testReport/projectroot.roottest.python.distrdf/dask/roottest_python_distrdf_dask_test_all/) - [projectroot.roottest.python.distrdf.spark.roottest_python_distrdf_spark_test_all](https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/152959/testReport/projectroot.roottest.python.distrdf/spark/roottest_python_distrdf_spark_test_all/)

[core/cling] modernize nullptr

Can one of the admins verify this patch?

[core/cling] modernize nullptr

Starting build on `ROOT-debian10-i386`/`cxx14`, `ROOT-performance-centos8-multicore`/`default`, `ROOT-ubuntu16`/`nortcxxmod`, `mac1014`/`python3`, `mac11.0`/`cxx17`, `windows10`/`cxx14` [How to customize builds](https://github.com/phsft-bot/build-configuration/blob/master/README.md)