root
root copied to clipboard
[core/cling] modernize nullptr
by clang-tidy
Can one of the admins verify this patch?
@phsft-bot build
Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds
redundant, already in base class
Note that the reason clang-tidy is recommending to remove the explicit setting of fType in the constructor is because it is already set in the class own's declaration (it is inlined in the declaration of the fType data member).
One comment: if we consider that these 'format' changes should not bloat the git history, we could add a .git-blame-ignore-revs, see more info:
https://www.moxio.com/blog/43/ignoring-bulk-change-commits-with-git-blame
any feedback on this PR ?
@phsft-bot build
Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds
Build failed on mac11/cxx17. Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.
Failing tests:
Build failed on windows10/cxx14. Running on null:C:\build\workspace\root-pullrequests-build See console output.
Failing tests:
Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds
Build failed on ROOT-debian10-i386/cxx14. Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build See console output.
Errors:
- [2022-03-31T23:09:49.915Z] stderr: error: Failed to merge in the changes.
- [2022-03-31T23:09:57.637Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1083 (message):
Build failed on mac11/cxx17. Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.
Errors:
- [2022-03-31T23:10:03.567Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1083 (message):
Build failed on ROOT-performance-centos8-multicore/default. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.
Errors:
- [2022-03-31T23:11:23.693Z] CMake Error at /data/sftnight/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1083 (message):
Build failed on ROOT-ubuntu16/nortcxxmod. Running on sft-ubuntu-1604-3.cern.ch:/build/workspace/root-pullrequests-build See console output.
Errors:
- [2022-03-31T23:13:08.451Z] stderr: error: Failed to merge in the changes.
- [2022-03-31T23:13:15.410Z] CMake Error at /mnt/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1083 (message):
Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds
Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds
Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds
Build failed on mac1015/cxx17. Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.
Failing tests:
Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds
Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.
Failing tests:
Build failed on windows10/cxx14. Running on null:C:\build\workspace\root-pullrequests-build See console output.
Failing tests:
- projectroot.roottest.root.meta.tclass.roottest_root_meta_tclass_libInitOrderDups_build
- projectroot.roottest.root.meta.tclass.issue-6767.roottest_root_meta_tclass_issue_6767_libRepro_build
- projectroot.roottest.root.meta.tclass.roottest_root_meta_tclass_libdatamemberload_build
- projectroot.roottest.root.meta.tclass.roottest_root_meta_tclass_libInitOrder_build
- projectroot.roottest.root.meta.tclass.issue-6840.roottest_root_meta_tclass_issue_6840_emulatePairs_build
- projectroot.roottest.root.multicore.roottest_root_multicore_current_dir_build
- projectroot.roottest.root.multicore.roottest_root_multicore_threadExecutor_build
- projectroot.roottest.root.multicore.roottest_root_multicore_tclass_methods_test_build
- projectroot.roottest.root.multicore.roottest_root_multicore_tSequentialExecutor_build
- projectroot.roottest.root.multicore.roottest_root_multicore_loadImt_build
And 193 more
@linev this one might fit with your latest merges (thanks!)
Idea to wait with cling changes until llvm upgrade.
Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds
Idea to wait with cling changes until llvm upgrade.
Rebased now.
Build failed on windows10/cxx14. Running on null:C:\build\workspace\root-pullrequests-build See console output.