root icon indicating copy to clipboard operation
root copied to clipboard

[core/cling] modernize nullptr

Open ferdymercury opened this issue 4 years ago • 24 comments
trafficstars

by clang-tidy

ferdymercury avatar May 27 '21 14:05 ferdymercury

Can one of the admins verify this patch?

phsft-bot avatar May 27 '21 14:05 phsft-bot

@phsft-bot build

pcanal avatar May 27 '21 16:05 pcanal

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14 How to customize builds

phsft-bot avatar May 27 '21 16:05 phsft-bot

redundant, already in base class

Note that the reason clang-tidy is recommending to remove the explicit setting of fType in the constructor is because it is already set in the class own's declaration (it is inlined in the declaration of the fType data member).

pcanal avatar May 29 '21 13:05 pcanal

One comment: if we consider that these 'format' changes should not bloat the git history, we could add a .git-blame-ignore-revs, see more info: https://www.moxio.com/blog/43/ignoring-bulk-change-commits-with-git-blame

ferdymercury avatar Aug 10 '21 10:08 ferdymercury

any feedback on this PR ?

ferdymercury avatar Oct 19 '21 09:10 ferdymercury

@phsft-bot build

Axel-Naumann avatar Jan 07 '22 09:01 Axel-Naumann

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14 How to customize builds

phsft-bot avatar Jan 07 '22 09:01 phsft-bot

Build failed on mac11/cxx17. Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Jan 07 '22 13:01 phsft-bot

Build failed on windows10/cxx14. Running on null:C:\build\workspace\root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Jan 07 '22 17:01 phsft-bot

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14 How to customize builds

phsft-bot avatar Mar 31 '22 23:03 phsft-bot

Build failed on ROOT-debian10-i386/cxx14. Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-03-31T23:09:49.915Z] stderr: error: Failed to merge in the changes.
  • [2022-03-31T23:09:57.637Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1083 (message):

phsft-bot avatar Mar 31 '22 23:03 phsft-bot

Build failed on mac11/cxx17. Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-03-31T23:10:03.567Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1083 (message):

phsft-bot avatar Mar 31 '22 23:03 phsft-bot

Build failed on ROOT-performance-centos8-multicore/default. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-03-31T23:11:23.693Z] CMake Error at /data/sftnight/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1083 (message):

phsft-bot avatar Mar 31 '22 23:03 phsft-bot

Build failed on ROOT-ubuntu16/nortcxxmod. Running on sft-ubuntu-1604-3.cern.ch:/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-03-31T23:13:08.451Z] stderr: error: Failed to merge in the changes.
  • [2022-03-31T23:13:15.410Z] CMake Error at /mnt/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1083 (message):

phsft-bot avatar Mar 31 '22 23:03 phsft-bot

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14 How to customize builds

phsft-bot avatar Mar 31 '22 23:03 phsft-bot

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14 How to customize builds

phsft-bot avatar Apr 29 '22 12:04 phsft-bot

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Aug 19 '22 11:08 phsft-bot

Build failed on mac1015/cxx17. Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Aug 19 '22 16:08 phsft-bot

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Aug 30 '22 11:08 phsft-bot

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Aug 30 '22 12:08 phsft-bot

@linev this one might fit with your latest merges (thanks!)

ferdymercury avatar Sep 14 '22 21:09 ferdymercury

Idea to wait with cling changes until llvm upgrade.

linev avatar Sep 15 '22 06:09 linev

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Dec 09 '22 10:12 phsft-bot

Idea to wait with cling changes until llvm upgrade.

Rebased now.

ferdymercury avatar Dec 09 '22 10:12 ferdymercury

Build failed on windows10/cxx14. Running on null:C:\build\workspace\root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Dec 09 '22 11:12 phsft-bot