root icon indicating copy to clipboard operation
root copied to clipboard

Published 20 hours ago • verified publisher icon root-project

Enhance support of cling cmd prompt func defining

Open jiangyilism opened this issue 3 years ago • 1 comments
trafficstars

Changes or fixes:

Let a_t be a c++ class, and we have done using std::ostream;. In standalone cling cmd prompt, all of the below function definitions fail to be parsed and compiled(incrementally).

::a_t& ::a_t::operator()(int k) {return *this; }
const a_t& a_t::operator[](int k) const {return *this; }
a_t::a_t() = default;
a_t::~a_t() = delete;
::a_t& ::a_t::operator()(int k) {return *this; }
std::ostream& operator>>(std::ostream& os, const a_t& a) {return (os << a.str << '\n');}
ostream& operator>>(std::ostream& os, const a_t& a) {return (os << a.str << '\n');}
const std::ostream& operator "" _tt(unsigned long long t) {return std::cout << "tt is " << t << '\n'; }
::a_t& operator>=(a_t &lhs, int t) {return lhs; }
a_t& operator<=(::a_t &lhs, int t) {return lhs; }
const a_t& operator<(a_t &lhs, int t) {return lhs; }
const ::a_t& operator>(a_t &lhs, int t) {return lhs; }

They get "error: function definition is not allowed here" due to cling::utils::getWrapPoint() wrongly determines to wrap function definition inside wrapper function __cling_Un1Qu3... . The root cause is that MinimalPPLexer::IsClassOrFunction() does not parse them as function definitions. This pullrequest enables MinimalPPLexer::IsClassOrFunction() to parse these kinds of func def but there are probably more edge cases of standard c++ func def not being recognized by MinimalPPLexer::IsClassOrFunction().

Checklist:

  • [X] tested changes locally
  • [ ] updated the docs (if necessary)

This PR fixes "error: function definition is not allowed here" ( https://github.com/root-project/cling/issues/184 ).

jiangyilism avatar Aug 28 '22 20:08 jiangyilism

Can one of the admins verify this patch?

phsft-bot avatar Aug 28 '22 20:08 phsft-bot

@phsft-bot build

jalopezg-git avatar Dec 22 '22 18:12 jalopezg-git

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Dec 22 '22 18:12 phsft-bot

Build failed on windows10/cxx14. See console output.

phsft-bot avatar Dec 22 '22 18:12 phsft-bot

@jiangyilism Thanks for the pull request; I'll review soon. I had an issue open for this since Dec 2021 (https://github.com/root-project/root/issues/9449)

jalopezg-git avatar Dec 22 '22 18:12 jalopezg-git

Build failed on ROOT-ubuntu18.04/nortcxxmod. Running on sft-ubuntu-1804-3.cern.ch:/build/workspace/root-pullrequests-build See console output.

Warnings:

  • [2022-12-22T18:32:30.793Z] /mnt/build/workspace/root-pullrequests-build/build/include/ROOT/RDataSource.hxx:213:11: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-12-22T18:32:30.793Z] /mnt/build/workspace/root-pullrequests-build/build/include/ROOT/RCsvDS.hxx:112:1: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-12-22T18:32:30.793Z] /mnt/build/workspace/root-pullrequests-build/build/include/ROOT/RSqliteDS.hxx:117:1: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-12-22T18:32:36.225Z] /mnt/build/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RDataSource.hxx:215:7: warning: ‘REMOVE_THIS_NOW’ attribute directive ignored [-Wattributes]
  • [2022-12-22T18:32:37.149Z] /mnt/build/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RDataSource.hxx:215:7: warning: ‘REMOVE_THIS_NOW’ attribute directive ignored [-Wattributes]
  • [2022-12-22T18:32:37.404Z] /mnt/build/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RDataSource.hxx:215:7: warning: ‘REMOVE_THIS_NOW’ attribute directive ignored [-Wattributes]
  • [2022-12-22T18:32:37.404Z] /mnt/build/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RCsvDS.hxx:114:114: warning: ‘REMOVE_THIS_NOW’ attribute directive ignored [-Wattributes]
  • [2022-12-22T18:32:39.256Z] /mnt/build/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RDataSource.hxx:215:7: warning: ‘REMOVE_THIS_NOW’ attribute directive ignored [-Wattributes]
  • [2022-12-22T18:32:40.617Z] /mnt/build/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RDataSource.hxx:215:7: warning: ‘REMOVE_THIS_NOW’ attribute directive ignored [-Wattributes]
  • [2022-12-22T18:32:42.500Z] /mnt/build/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RDataSource.hxx:215:7: warning: ‘REMOVE_THIS_NOW’ attribute directive ignored [-Wattributes]

And 60 more

Failing tests:

phsft-bot avatar Dec 22 '22 19:12 phsft-bot

Build failed on ROOT-performance-centos8-multicore/cxx17. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-12-22T19:00:01.557Z] 1219/2420 Test #934: tutorial-roostats-IntervalExamples ................................................................***Failed Error regular expression found in output. Regex=[: error:] 0.86 sec
  • [2022-12-22T19:00:01.818Z] 1222/2420 Test #931: tutorial-roostats-FourBinInstructional ............................................................***Failed Error regular expression found in output. Regex=[: error:] 1.11 sec
  • [2022-12-22T19:00:02.090Z] 1223/2420 Test #936: tutorial-roostats-OneSidedFrequentistUpperLimitWithBands ..........................................***Failed Error regular expression found in output. Regex=[: error:] 0.85 sec
  • [2022-12-22T19:00:02.090Z] 1224/2420 Test #939: tutorial-roostats-StandardFeldmanCousinsDemo ......................................................***Failed Error regular expression found in output. Regex=[: error:] 0.71 sec
  • [2022-12-22T19:00:03.137Z] 1232/2420 Test #948: tutorial-roostats-TwoSidedFrequentistUpperLimitWithBands ..........................................***Failed Error regular expression found in output. Regex=[: error:] 1.00 sec
  • [2022-12-22T19:00:03.981Z] 1243/2420 Test #950: tutorial-roostats-rs101_limitexample ..............................................................***Failed Error regular expression found in output. Regex=[: error:] 1.59 sec
  • [2022-12-22T19:00:04.491Z] 1245/2420 Test #954: tutorial-roostats-rs401c_FeldmanCousins ...........................................................***Failed Error regular expression found in output. Regex=[: error:] 1.14 sec

Warnings:

  • [2022-12-22T18:55:01.486Z] /data/sftnight/workspace/root-pullrequests-build/build/include/ROOT/RDataSource.hxx:213:11: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-12-22T18:55:02.813Z] /data/sftnight/workspace/root-pullrequests-build/build/include/ROOT/RCsvDS.hxx:112:1: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-12-22T18:55:03.069Z] /data/sftnight/workspace/root-pullrequests-build/build/include/ROOT/RSqliteDS.hxx:117:1: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-12-22T18:55:03.069Z] /data/sftnight/workspace/root-pullrequests-build/build/include/ROOT/RNTupleDS.hxx:96:1: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-12-22T18:55:03.069Z] /data/sftnight/workspace/root-pullrequests-build/build/include/ROOT/RNTupleDS.hxx:98:1: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-12-22T18:55:14.359Z] /data/sftnight/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RDataSource.hxx:215:7: warning: ‘REMOVE_THIS_NOW’ attribute directive ignored [-Wattributes]
  • [2022-12-22T18:55:16.631Z] /data/sftnight/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RCsvDS.hxx:114:114: warning: ‘REMOVE_THIS_NOW’ attribute directive ignored [-Wattributes]
  • [2022-12-22T18:55:16.900Z] /data/sftnight/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RSqliteDS.hxx:118:81: warning: ‘REMOVE_THIS_NOW’ attribute directive ignored [-Wattributes]
  • [2022-12-22T18:55:16.900Z] /data/sftnight/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RNTupleDS.hxx:97:86: warning: ‘REMOVE_THIS_NOW’ attribute directive ignored [-Wattributes]
  • [2022-12-22T18:55:16.900Z] /data/sftnight/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RNTupleDS.hxx:99:47: warning: ‘REMOVE_THIS_NOW’ attribute directive ignored [-Wattributes]

And 130 more

Failing tests:

And 7 more

phsft-bot avatar Dec 22 '22 19:12 phsft-bot

Build failed on mac12/noimt. Running on macphsft18.dyndns.cern.ch:/Users/sftnight/build/jenkins/workspace/root-pullrequests-build See console output.

Warnings:

  • [2022-12-22T18:52:34.160Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/build/include/ROOT/RDataSource.hxx:213:11: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-12-22T18:52:34.160Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/build/include/ROOT/RCsvDS.hxx:112:1: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-12-22T18:52:34.160Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/build/include/ROOT/RSqliteDS.hxx:117:1: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-12-22T18:52:34.160Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RDataSource.hxx:213:11: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-12-22T18:52:34.160Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RDataSource.hxx:213:11: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-12-22T18:52:34.160Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RDataSource.hxx:213:11: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-12-22T18:52:34.161Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RDataSource.hxx:213:11: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-12-22T18:52:34.161Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RDataSource.hxx:213:11: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-12-22T18:52:34.161Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RCsvDS.hxx:112:1: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-12-22T18:52:34.161Z] /Users/sftnight/build/jenkins/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RDataSource.hxx:213:11: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]

And 53 more

Failing tests:

phsft-bot avatar Dec 22 '22 19:12 phsft-bot

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Warnings:

  • [2022-12-22T18:50:34.850Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RDataSource.hxx:213:11: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-12-22T18:50:34.850Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RCsvDS.hxx:112:1: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-12-22T18:50:34.850Z] /home/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RSqliteDS.hxx:117:1: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-12-22T18:50:34.850Z] /home/sftnight/build/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RDataSource.hxx:215:7: warning: ‘REMOVE_THIS_NOW’ attribute directive ignored [-Wattributes]
  • [2022-12-22T18:50:34.850Z] /home/sftnight/build/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RCsvDS.hxx:114:114: warning: ‘REMOVE_THIS_NOW’ attribute directive ignored [-Wattributes]
  • [2022-12-22T18:50:34.850Z] /home/sftnight/build/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RDataSource.hxx:215:7: warning: ‘REMOVE_THIS_NOW’ attribute directive ignored [-Wattributes]
  • [2022-12-22T18:50:34.850Z] /home/sftnight/build/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RDataSource.hxx:215:7: warning: ‘REMOVE_THIS_NOW’ attribute directive ignored [-Wattributes]
  • [2022-12-22T18:50:34.850Z] /home/sftnight/build/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RCsvDS.hxx:114:114: warning: ‘REMOVE_THIS_NOW’ attribute directive ignored [-Wattributes]
  • [2022-12-22T18:50:34.850Z] /home/sftnight/build/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RSqliteDS.hxx:118:81: warning: ‘REMOVE_THIS_NOW’ attribute directive ignored [-Wattributes]
  • [2022-12-22T18:50:34.850Z] /home/sftnight/build/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RDataSource.hxx:215:7: warning: ‘REMOVE_THIS_NOW’ attribute directive ignored [-Wattributes]

And 54 more

Failing tests:

phsft-bot avatar Dec 22 '22 19:12 phsft-bot

Build failed on mac11/cxx14. Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2022-12-22T19:34:19.056Z] 1024/2362 Test #913: tutorial-roostats-FourBinInstructional ............................................................***Failed Error regular expression found in output. Regex=[: error:] 0.95 sec
  • [2022-12-22T19:34:19.873Z] 1026/2362 Test #916: tutorial-roostats-IntervalExamples ................................................................***Failed Error regular expression found in output. Regex=[: error:] 0.78 sec
  • [2022-12-22T19:34:21.257Z] 1029/2362 Test #918: tutorial-roostats-OneSidedFrequentistUpperLimitWithBands ..........................................***Failed Error regular expression found in output. Regex=[: error:] 1.13 sec
  • [2022-12-22T19:34:22.696Z] 1032/2362 Test #921: tutorial-roostats-StandardFeldmanCousinsDemo ......................................................***Failed Error regular expression found in output. Regex=[: error:] 0.77 sec
  • [2022-12-22T19:34:34.880Z] 1041/2362 Test #930: tutorial-roostats-TwoSidedFrequentistUpperLimitWithBands ..........................................***Failed Error regular expression found in output. Regex=[: error:] 0.86 sec
  • [2022-12-22T19:34:36.734Z] 1043/2362 Test #932: tutorial-roostats-rs101_limitexample ..............................................................***Failed Error regular expression found in output. Regex=[: error:] 1.68 sec
  • [2022-12-22T19:34:40.367Z] 1047/2362 Test #936: tutorial-roostats-rs401c_FeldmanCousins ...........................................................***Failed Error regular expression found in output. Regex=[: error:] 0.96 sec

Warnings:

  • [2022-12-22T19:19:00.380Z] /Users/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RDataSource.hxx:213:11: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-12-22T19:19:00.381Z] /Users/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RCsvDS.hxx:112:1: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-12-22T19:19:00.381Z] /Users/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/RSqliteDS.hxx:117:1: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-12-22T19:19:39.994Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RDataSource.hxx:213:11: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-12-22T19:19:43.315Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RDataSource.hxx:213:11: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-12-22T19:19:44.735Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RDataSource.hxx:213:11: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-12-22T19:19:45.685Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RDataSource.hxx:213:11: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-12-22T19:19:47.077Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RDataSource.hxx:213:11: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-12-22T19:19:48.018Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RDataSource.hxx:213:11: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]
  • [2022-12-22T19:19:50.620Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/tree/dataframe/inc/ROOT/RDataSource.hxx:213:11: warning: unknown attribute 'REMOVE_THIS_NOW' ignored [-Wunknown-attributes]

And 54 more

Failing tests:

And 7 more

phsft-bot avatar Dec 22 '22 20:12 phsft-bot

@phsft-bot build

jalopezg-git avatar Jan 11 '23 20:01 jalopezg-git

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14 How to customize builds

phsft-bot avatar Jan 11 '23 20:01 phsft-bot

Build failed on mac11/cxx14. Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Jan 11 '23 21:01 phsft-bot

jalopezg-git

Thanks for the review. I will address the issues and add test cases in interpreter/cling/test/ .

jiangyilism avatar Jan 19 '23 15:01 jiangyilism

@jiangyilism, any progress in this regard?

jalopezg-git avatar Apr 17 '23 19:04 jalopezg-git

Any progress? I am college teacher and I can't teach student to overload cout<<Object in cling due to this issue!

mylyu avatar Jun 04 '23 08:06 mylyu

Any progress? I am college teacher and I can't teach student to overload cout<<Object in cling due to this issue!

Thanks for expressing interest @mylyu! :+1: If @jiangyilism is not able to follow-up on this, I can take it in a couple of weeks or so.

jalopezg-git avatar Jun 04 '23 21:06 jalopezg-git

@jalopezg-git Sorry for the late reply. I am still trying to fix some corner cases while avoiding too intrusive changes. I will update the pull request soon.

jiangyilism avatar Jun 05 '23 09:06 jiangyilism

Many thanks.

Jiang Yi @.***> 于 2023年6月5日周一 05:15写道：

@jalopezg-git https://github.com/jalopezg-git Sorry for the late reply. I am still trying to fix some corner cases while avoiding too intrusive changes. I will update the pull request soon.

— Reply to this email directly, view it on GitHub https://github.com/root-project/root/pull/11265#issuecomment-1576431258, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACN3SSVEF3GLBPRSV2CHAELXJWPUNANCNFSM573UE76Q . You are receiving this because you were mentioned.Message ID: @.***>

mylyu avatar Jun 05 '23 16:06 mylyu

https://github.com/SdtElectronics/cline/issues/10 and https://github.com/root-project/cling/issues/490 redirect the discussion of parsing noexcept to here. However I suggest to address it in another dedicate issue and pull request for it (or re-open the above issues). Currently cling seems to not parse noexcept at all. At least not at lexer/token level since string-searching kw_noexcept got nothing in root/interpreter/cling/ directory.

jiangyilism avatar Jun 07 '23 14:06 jiangyilism

SdtElectronics/cline#10 and root-project/cling#490 redirect the discussion of parsing noexcept to here. However I suggest to address it in another dedicate issue and pull request for it (or re-open the above issues). Currently cling seems to not parse noexcept at all. At least not at lexer/token level since string-searching kw_noexcept got nothing in root/interpreter/cling/ directory.

Many thanks @jiangyilism. Please, re-request a code review when you think it is ready :slightly_smiling_face:!

jalopezg-git avatar Jun 08 '23 09:06 jalopezg-git

Test Results

       10 files         10 suites   1d 23h 44m 22s :stopwatch:   2 472 tests   2 472 :heavy_check_mark: 0 :zzz: 0 :x: 23 065 runs  23 065 :heavy_check_mark: 0 :zzz: 0 :x:

Results for commit ba17dc40.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jun 08 '23 15:06 github-actions[bot]

SdtElectronics/cline#10 and root-project/cling#490 redirect the discussion of parsing noexcept to here. However I suggest to address it in another dedicate issue and pull request for it (or re-open the above issues). Currently cling seems to not parse noexcept at all. At least not at lexer/token level since string-searching kw_noexcept got nothing in root/interpreter/cling/ directory.

Many thanks @jiangyilism. Please, re-request a code review when you think it is ready 🙂!

It is ready for review. However I have no clue about the failure test report above. clang-format failed to checkout code before running. The windows test fail seems to be file permission error irrelevant to this pull request. The Fedora test fail is unreproducible on my ubuntu either.

jiangyilism avatar Jun 12 '23 11:06 jiangyilism

@phsft-bot build

jalopezg-git avatar Jun 15 '23 10:06 jalopezg-git

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/cxx14 How to customize builds

phsft-bot avatar Jun 15 '23 10:06 phsft-bot

Build failed on ROOT-ubuntu2204/nortcxxmod. Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Errors:

  • [2023-06-15T10:30:11.698Z] /home/sftnight/build/workspace/root-pullrequests-build/root/math/mathcore/src/Delaunay2D.cxx:323:40: error: ‘numeric_limits’ is not a member of ‘std’
  • [2023-06-15T10:30:11.698Z] /home/sftnight/build/workspace/root-pullrequests-build/root/math/mathcore/src/Delaunay2D.cxx:323:55: error: expected primary-expression before ‘double’

phsft-bot avatar Jun 15 '23 10:06 phsft-bot

Build failed on mac12arm/cxx20. Running on macphsft26.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Jun 15 '23 14:06 phsft-bot

@phsft-bot build

jalopezg-git avatar Jul 05 '23 10:07 jalopezg-git

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/cxx14 How to customize builds

phsft-bot avatar Jul 05 '23 10:07 phsft-bot

Build failed on ROOT-ubuntu2004/python3. Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

phsft-bot avatar Jul 05 '23 10:07 phsft-bot