Impact
Impact copied to clipboard
phoboslab
HTML5 Game Engine
https://github.com/phoboslab/Impact/blob/6d06c2853294717cb7f078cae54c46996d15151c/lib/impact/debug/maps-panel.js#L49 Probably ought to be: ```js var head = ig.$new('strong'); ``` I'm not even sure why the original doesn't throw an error, because all `ig.$new` does is https://github.com/phoboslab/Impact/blob/6d06c2853294717cb7f078cae54c46996d15151c/lib/impact/impact.js#L110-L111 and `new...
https://github.com/phoboslab/Impact/blob/1425a041e3a85fa00bc8e7a86d6f84aab67a6104/lib/impact/loader.js#L4-L8 As far as I can tell, none of these are actually used within the `ig.Loader` class/module... Edit: It's for sure possible to have a game that doesn't use any...
```diff diff --git a/lib/impact/sound.js b/lib/impact/sound.js index 50d74be..afcc7a4 100644 --- a/lib/impact/sound.js +++ b/lib/impact/sound.js @@ -34,13 +34,13 @@ ig.SoundManager = ig.Class.extend({ if( ig.Sound.enabled && ig.Sound.useWebAudio ) { this.audioContext = new AudioContext(); this.boundWebAudioUnlock...
Apparently the `mousewheel` event implemented by Impact https://github.com/phoboslab/Impact/blob/b8f633c793b2fffc4614625f00ced3c18687cf92/lib/impact/input.js#L120 is not current and should not be used, according to: https://developer.mozilla.org/en-US/docs/Web/API/Element/mousewheel_event and that link suggests using the following instead: https://developer.mozilla.org/en-US/docs/Web/API/Element/wheel_event
Is the version of Impact that was uploaded to Github missing some of the later changes? Here's a commit that shows Dominic adding a line to Input.js back in 2015:...
https://github.com/phoboslab/Impact/blob/f461c2f4054dac37dea351d8fe3440eae6a2f47e/lib/weltmeister/modal-dialogs.js#L31
https://github.com/phoboslab/Impact/blob/f461c2f4054dac37dea351d8fe3440eae6a2f47e/lib/weltmeister/weltmeister.js#L466 There should probably be a space after the `:` to match the style of the lines above it.
Could someone please help me regarding this? https://stackoverflow.com/questions/77377483/import-debugout-js-with-an-impact-js-project
Discuss about `rvx, rvy` in `collection-map.js` there is a function with arguments named `rvx, rvy` , What do they mean? what's the full name ? https://github.com/phoboslab/Impact/blob/7768fd29c70ca924a78673d93081baab5a72fbe6/lib/impact/collision-map.js#L63 ------ the `_traceStep()` be...
This is not a real PR. Just for comparing the differences in the code