Impact icon indicating copy to clipboard operation
Impact copied to clipboard

Github Version of Impact Not Up To Date?

Open Joncom opened this issue 6 years ago • 1 comments

Is the version of Impact that was uploaded to Github missing some of the later changes?

Here's a commit that shows Dominic adding a line to Input.js back in 2015:

$ git show 9333a38c
commit 9333a38c6d35f4dfd1ecc7cece5f3a7a4becfca7
Author: phoboslab <[email protected]>
Date:   Sun Oct 18 18:32:42 2015 +0200

    Release button when touch is canceled; thanks @Joncom

diff --git a/lib/impact/input.js b/lib/impact/input.js
index b1fa2fb..f9edd27 100644
--- a/lib/impact/input.js
+++ b/lib/impact/input.js
@@ -129,6 +129,7 @@ ig.Input = ig.Class.extend({
                        // Standard
                        ig.system.canvas.addEventListener('touchstart', this.keydown.bind(this), false );
                        ig.system.canvas.addEventListener('touchend', this.keyup.bind(this), false );
+                       ig.system.canvas.addEventListener('touchcancel', this.keyup.bind(this), false );
                        ig.system.canvas.addEventListener('touchmove', this.mousemove.bind(this), false );

                        // MS

However, if we look at the history for that file, the commit is not on Github... https://github.com/phoboslab/Impact/commits/master/lib/impact/input.js

Edit: Just patched it in manually... https://github.com/phoboslab/Impact/commit/b8f633c793b2fffc4614625f00ced3c18687cf92

Joncom avatar Jul 21 '19 13:07 Joncom

I see only one other commit (present in my local copy of Impact but) missing from the Github repo:

$ git show 6593b1be07eb683565dca3282e64d5359670e306
commit 6593b1be07eb683565dca3282e64d5359670e306 (HEAD -> master, bitbucket/master)
Author: phoboslab <[email protected]>
Date:   Mon Apr 4 22:10:43 2016 +0200

    Workaround for Chrome 49 bug, slow offscreen canvases. Thanks @zachstronaut

diff --git a/lib/impact/image.js b/lib/impact/image.js
index 47d124a..f103a73 100644
--- a/lib/impact/image.js
+++ b/lib/impact/image.js
@@ -108,7 +108,12 @@ ig.Image = ig.Class.extend({
                        }
                }
                scaledCtx.putImageData( scaledPixels, 0, 0 );
-               this.data = scaled;
+
+               // Workaround for Chrome 49 bug - handling many offscreen canvases
+               // seems to slow down the browser significantly. So we convert the
+               // upscaled canvas back to an image.
+               this.data = new Image();
+               this.data.src = scaled.toDataURL();
        },

Not sure if this should be patched back in or not...

Joncom avatar Jul 21 '19 13:07 Joncom