Impact icon indicating copy to clipboard operation
Impact copied to clipboard

ig.Loader requires unnecessary modules?

Open Joncom opened this issue 6 years ago • 0 comments

https://github.com/phoboslab/Impact/blob/1425a041e3a85fa00bc8e7a86d6f84aab67a6104/lib/impact/loader.js#L4-L8

As far as I can tell, none of these are actually used within the ig.Loader class/module...

Edit:

It's for sure possible to have a game that doesn't use any ig.Font, but by requiring it here, the font code will still get baked into the final output, unnecessarily.

One could argue that some of those required modules do get used in the loader, because they are populated into the resources array, and then manipulated via methods such as .load...

Joncom avatar Aug 04 '19 08:08 Joncom