John Mulligan

Results 150 comments of John Mulligan

We can certainly look to improve the documentation here. I would hesitate to change the behavior of these functions as they've been based on their corresponding librados functions quite a...

Probably relevant: https://github.com/golang/go/issues/34409 https://github.com/golang/go/issues/45497 From what I see there's no easy way out. Options that are valid today are pretty limited. I wish the Go ecosystem liked static doc generation...

More searching around wrt to the idea of generating static docs lead me to find https://github.com/readthedocs/godocjson and https://bitbucket.org/ymotongpoo/sphinxcontrib-golangdomain/src/master/ both of which look rather unmaintained. However, that doesn't necessarily mean they...

@nixpanic @ansiwen @agarwal-mudit anyone interested in taking this up? I still think we ought to do this as well as other cleanups around snapshots in rbd and then deprecate the...

Certainly, I'd love to see someone take this up. Let me know if you would like to have a more detailed discussion about the design aspects. We can take that...

> @phlogistonjohn How would you solve it? > I would start by adding a new method to the Image. Something like `func (image *Image) SetSnapshot(name string) error`. Then I would...

After a lot of pondering I've come up with a 2nd approach that is very clear to read and avoids some of the issues I have with writing generic code...

@nixpanic do you think this is sufficiently covered by the previous retry work? I did a quick audit of the code and the only "weird" use of ERANGE at this...

Hi, thanks for the contribution! The CI is failing due to some of the doc comments not meeting the standard form. If you have any questions about the typical form...

> Do we really have to make all new API change preview? That's the current plan yes. There was a github [discussions thread](https://github.com/ceph/go-ceph/discussions/525) created a while back as well as...