rgw/admin: add support for new /info section

[mattbenjamin]

Implement support for new /info AdminOps interface, which returns an extensible json record similar to:

{"info":{"storage_backends":[{"name":"rados","cluster_id":"75d1938b-2949-4933-8386-fb2d1449ff03"}]}}

Signed-off-by: Matt Benjamin [email protected]

Checklist

• [ ] Added tests for features and functional changes
• [ ] Public functions and types are documented
• [ ] Standard formatting is applied to Go code
• [ ] Is this a new API? Is this new API marked PREVIEW?

[mattbenjamin]

@leseb I was having trouble running our own test suite locally, so decided to try with the go-ceph code

[phlogistonjohn]

Hi, thanks for the contribution! The CI is failing due to some of the doc comments not meeting the standard form. If you have any questions about the typical form for Go doc comment, please feel free to ask.

We also have a new policy of tagging new API as preview. See the stability doc and the dev doc. Again, if you have any questions please just ask. Thanks!

[leseb]

Hi, thanks for the contribution! The CI is failing due to some of the doc comments not meeting the standard form. If you have any questions about the typical form for Go doc comment, please feel free to ask.

We also have a new policy of tagging new API as preview. See the stability doc and the dev doc. Again, if you have any questions please just ask. Thanks!

Do we really have to make all new API change preview?

[phlogistonjohn]

Do we really have to make all new API change preview?

That's the current plan yes. There was a github discussions thread created a while back as well as some doc covering the recent changes: policy, dev guide. This is the first cycle where we're "enforcing" the policy in the CI and code reviews.

If you have suggestions on changes to the policy I'd recommend you create a new thread in the discussion - I'm certainly open to changes but I want to make sure it's widely visible. But for the current PRs I'd like to be consistent and apply it evenly, I hope you understand. :-)

[phlogistonjohn]

Hi all, it's been a while since this PR saw any activity. Based on previous comments I assume @mattbenjamin is not interested in driving this to completion. @leseb are you? If not should/can we find someone who is? It looks like a good thing to have and I think it would be good to get it in some form or another.

Thanks!

[mattbenjamin]

Hi all, it's been a while since this PR saw any activity. Based on previous comments I assume @mattbenjamin is not interested in driving this to completion. @leseb are you? If not should/can we find someone who is? It looks like a good thing to have and I think it would be good to get it in some form or another.

Thanks!

oh, come on; just busy

[leseb]

Hi all, it's been a while since this PR saw any activity. Based on previous comments I assume @mattbenjamin is not interested in driving this to completion. @leseb are you? If not should/can we find someone who is? It looks like a good thing to have and I think it would be good to get it in some form or another.

Thanks!

I don't have time right now to take this over. Eventually, I might.

[phlogistonjohn]

Thanks all, sorry if I misunderstood the original discussion as well.

We'll be patient with this PR. PRs in go-ceph don't go stale/expire but I do try to make sure open PRs in the project are not abandoned. That's all I needed to know.

[mattbenjamin]

sorry, I'll try to hot this up

[github-actions[bot]]

This Pull Request has been automatically marked as stale because it has not had recent activity. It will be closed in 21 days if no further activity occurs. Remember, a closed PR can always be reopened. Thank you for your contribution.

[github-actions[bot]]

This Pull Request has been automatically closed due to inactivity. In the future, if you resume working on this again, the PR can be reopened. Additionally, if you are proposing a feature or fix that you think someone else could take up - please say so - and if there is no existing issue already, file an issue for the topic. Thank you for your contribution.