Philippe Scorsolini
Philippe Scorsolini
@georgebarbarosie can you check the error with the DCO? https://github.com/cloudnative-pg/charts/runs/14778552401
Can you remove the bump to the version? Otherwise looks good to me, thanks for switching to false by default 🙏
@winston0410 sure, PRs are definitely welcome! We kind of try to keep the chart as lean as possible, so unfortunately sometimes we have to reject some PR, but this one...
@sttts, this PR is marked as ready for review, but has WIP in the title, should we move it to draft or consider it actually ready for review?
Isn't this the exact thing happening with plain CustomResourceDefinitions (CRD)? I think that's how defaults are supposed to work.
Hi, thanks @HouqiyuA, we do have scans in CI and renovate configured to bump dependencies, so of the two reported vulnerabilities: - CVE-2024-24786: we already bumped the dependency in master...
Indeed it looks like for some reason the cache was not updated yet and therefore Crossplane is not able to find the XR 🤔 However, AFAICT, Crossplane should try again...
You are right @duizabojul, it was automatically closed because the description of https://github.com/crossplane/crossplane-runtime/pull/641 mentioned fixing this.
Relevant to the discussion here: https://github.com/crossplane/crossplane/pull/5061
Sounds reasonable to me, we should probably error if more than one input is "-" to avoid hanging indefinitely.