charts icon indicating copy to clipboard operation
charts copied to clipboard

feat(cloudnative-pg): Add structured field monitoringQueriesConfigMap.queriesData

Open georgebarbarosie opened this issue 2 years ago • 2 comments

Uses same syntax as queries, but it's plain Yaml instead of yaml-as-string. The values in both fields are merged, with queriesData overriding values from queries.

We pass queries through fromYaml, we then merge it with queriesData and use the result as the final value in the ConfigMap.

The advantage of this is that it allows people to override specific queries in the default queries value and it allows composability for those that use e.g. kustomizations to compile the values of the chart (gitops, fluxcd, etc).

georgebarbarosie avatar Jul 04 '23 22:07 georgebarbarosie

@georgebarbarosie can you check the error with the DCO? https://github.com/cloudnative-pg/charts/runs/14778552401

phisco avatar Jul 05 '23 08:07 phisco

@georgebarbarosie can you check the error with the DCO? https://github.com/cloudnative-pg/charts/runs/14778552401

Done. Apologies, I wasn't aware of the requirement.

georgebarbarosie avatar Jul 05 '23 09:07 georgebarbarosie