phiresky

Results 402 comments of phiresky

@dullbananas Maybe instead of those structs it would be easier to make the `get_conn` function a trait? something like... ```rust trait GetConn { fn get_conn(&mut self) -> &mut AsyncPgConnection; }...

Would be good to try with just debug=0 because those symbols are really useful for stack traces (e.g. anyhow errors, the use of tracing spans isn't consistent everywhere) and i...

comparison: ![image](https://github.com/LemmyNet/lemmy/assets/2303841/be99c02c-3b99-4d74-8f84-4d02b77684a9)

There's many config options for full-text-search with sqlite. I don't remember if I wrote my research about this down somewhere but you can reduce the FTS size by >90% by...

Also just as a note if you have too much free time: If you download the whole DB then you can alternatively also create a minimal db without indexes and...

This is a good observation. I'm a fan of the STRICT option too, but I didn't notice it caused an issue here. Abusing the text field to store blobs is...

> switching the column in the rewritten table to be of type "any", That would probably work. Then both uncompressed text and compressed blobs could be in the column. But...

If you use the "base" set of functions (zstd_train_dict, zstd_compress, zstd_dcompress), then you can handle dictionaries however you want (store them as blobs in a separate table, identified however you...

One more comment: I think this PR needs a general motivation section: It's not obvious why it is would be a good idea to circumvent the migration method for triggers...

> However browsers cant handle this url scheme by default and show an error message instead: Not sure about this approach exactly, but lemmy-ui could in Firefox and Chrome register...