phiresky

Results 402 comments of phiresky

> Have you tested if this new code for activity sending works I have tested the basic federation functionality manually and it did work. I did not test extensively whether...

@Nutomic I don't think the ActivityChannel does much anymore with activity sending now doing nothing except storing a value in the database. Could you say what you think of this...

> The synchronous federation is needed for api tests, to ensure that api calls are fully completed by the same that asserts are executed. If we make api tests async,...

There was one more issue in the federation tests due to a race condition in the initialization (that i think only happens in testing) . I've fixed it. I've still...

There's one more issue where if a user is deleted it is no longer found and the federation worker can error out. I'll fix that by both skipping internal errors...

That looks bad. Did you also try turning the `[profile.dev] debug =0` option back on and see if that helps? i changed that in some pr last week and thought...

screeenshot of timings on current main: ![image](https://github.com/LemmyNet/lemmy/assets/2303841/63a5f178-d5d3-464a-97ff-fb4671181461) ![image](https://github.com/LemmyNet/lemmy/assets/2303841/219a7a55-7893-4d48-8cab-fd7d0a130d26)

Doesn't look extremely useful, but: ``` $ cargo rustc --bin lemmy_server -- -Zself-profile $ summarize summarize lemmy_server-3845390.mm_profdata -p 3 +------------------------------+-----------+-----------------+----------+------------+-----------------------+---------------------------------+ | Item | Self time | % of total time...

> @phiresky What does that mean? Nothing changeable for this issue I guess, you can ignore it. I also had the thing where incremental builds sometimes took 2min and sometimes...