phiresky

Awesome! > use exists and transaction to check that sent activity wasnt inserted before. on_conflict_do_nothing() I want to mention that wrapping it in a transaction does nothing here - Postgresql...

The returning line is *only* used if the insert was successful. If it wasn't, then it won't return anything. Check this example:  You can maybe add it before the...

You tried with `.optional()` after `.get_result()`? after importing https://docs.diesel.rs/master/diesel/result/trait.OptionalExtension.html. it's an extension trait for some reason

In my opinion (and something I've done with success in the past) a good compromise would be to use a JSON blob on the postgresql side, but that is fully...

> The main question for me is why you decided to implement this in Lemmy, and not in the federation library Mainly for simplicity. I don't think the activitypub-federation crate...

Ah, another reason is that I add signal handlers for clean shutdown, since that can take multiple seconds (up to the http timeout). So if it was in the same...

Updated: * rebased on latest main branch (specifically the sent_activity split from #3583 ) * added dead instance detection from #3427 to the federation worker start / stop logic *...

I've made the following changes * restructured worker.rs into a struct with member methods, no more nested loops * other nutomic comments * removed the lemmy_federate entry point. instead, it's...

I've updated this PR to use cleaner / simpler code changes to activitypub-federation https://github.com/LemmyNet/activitypub-federation-rust/pull/75 I've also fixed the CI.

I've updated this to accommodate the timezone PR merged into master.