Phillip Webb
Phillip Webb
> would it be possible to use a wrapper class that checks if AssertJ is available on the classpath and if not, falls back to hamcrest Unfortunately not because we...
> For example, after the invocation of mockMvc.perform(get("/")), we could introduce a branch -- for example mockMvc.perform(get("/")).fluent(), mockMvc.perform(get("/")).assertJ(), or something I'd need to brush up on my classloading knowledge. If...
I'm not 100% sure what's going on, but I suspect that the binder being used in [this line](https://github.com/spring-cloud/spring-cloud-consul/blob/5dfa604a4fde36fe08722bed1fae8495798ebe82/spring-cloud-consul-discovery/src/main/java/org/springframework/cloud/consul/discovery/configclient/ConsulConfigServerBootstrapper.java#L54) is wrong or stale. Ideally, the binder should only be used in...
We discussed this today and given that JMX support will be dropped in Log4j 3.0 we don't think we should add support directly in Spring Boot. We want to keep...
Thanks @sdavids, I somehow missed that comment. I've opened #42272 to deal with that.
Thanks for the suggestion, but we're not keen to add any more complexity to this area.
We're cleaning out the issue tracker and closing issues that we've not seen much demand to fix. Feel free to comment with additional justifications if you feel that this one...
We'll take another look at this and reconsider the original decision.
Yeah, that sounds like a good compromise. It's pretty much the same as the code in https://github.com/spring-projects/spring-boot/issues/33748#issue-1528161847, but I feel more comfortable with it being in the `spring-session` codebase. At...
It doesn't look like there's any single candidate that would work as a drop-in replacement, but we could perhaps isolate ourselves a little by not using JSONAssert types in our...