Phillip Webb

Results 467 comments of Phillip Webb

I've pushed something to Spring Boot that will allow imported `ConfigData` items to indicate that specific property sources should be considered "profile specific".

We should also look at #38754 before we merge this.

Some debugging shows that the classloader used when trying to enhance `org.example.bugspringsecurityjpms.BugSpringSecurityJpmsApplication` is the `AppClassLoader`, despite the `RestartClassLoader` being set [here](https://github.com/spring-projects/spring-framework/blob/ccf9ba86a035bd54acea70a5bff13ad9bb1838ba/spring-context/src/main/java/org/springframework/context/annotation/ConfigurationClassPostProcessor.java#L538).

@xenoterracide If you're not directly calling bean methods in your `@Configuration` class you can try doing `@SpringBootApplication(proxyBeanMethods = false)` so that the proxy isn't created.

FWIW the sample in https://github.com/spring-projects/spring-boot/issues/26578 does use devtools but for some reason the `RestartClassLoader` isn't being used when the enhancer runs.

It would be nice to contribute some ideas to https://github.com/assertj/assertj/issues/2817. If we has a `SoftAssertProvider` we might be able to do: ```java SoftAssertions.assertSoftly(softly -> { softly.assertThat(context) .doesNotHaveBean(...) .hasSingleBean(...); }); ```

I might be a bit biased, but I personally quite liked the logic being in the `DurationStyle` enum rather than another `*Utils` class. Especially as `DurationFormatterUtils` now depends on an...

I missed the existing `org.springframework.format.datetime.standard` -> `org.springframework.format.annotation` dependency. That does indeed complicate things! I wonder what `DurationFormatterUtils` would look like if it didn't use enums from `org.springframework.format.annotation`? Perhaps it could...

There's a comment on https://github.com/spring-projects/spring-boot/issues/37562#issuecomment-2036949439 which might be relevant to this feature. It would be nice to support Kotlin `1.5s` style values.

I think this is a bug, but for what it's worth I don't think it makes as much sense to use `Validator` with constructor binding. For setter based binding, it's...