Philip Niedertscheider

Results 164 comments of Philip Niedertscheider

After a discussion the existing tests are valid, therefore indicating that my changes in this PR are not valid yet.

I manually confirmed that this actually fixes the issue with session replay by using the `Close SDK` and `Start SDK` buttons in the Sample App > Extras tab.

I am not sure right now if you want us to review this, as the title indicates `WIP` but the PR is marked as ready-for-review. Please clarify.

From Cocoa Sync 08/16:We need to investigate if the `windows` are not used anywhere else and instead just return the data that is requested from the `windows` so all access...

From Cocoa Sync 06/18:We need to look into the proposed changes of [https://github.com/getsentry/sentry-cocoa/pull/5220](https://github.com/getsentry/sentry-cocoa/pull/5220) again, but @philipphofmann believes that a test plan will not help and instead we need to evaluate...

> But more broadly, why is this more realistic than calling a sleep? I don't think it's possible for any frames to be rendered while this loop is executing. It...

Can we mark this PR as draft or close it until v9?

I'll change it to draft because we are not ready for it yet.

Thank you @denrase for implementing our feedback 👍

Another list of potential candidates https://swiftpackageindex.com/keywords/logging