sentry-cocoa icon indicating copy to clipboard operation
sentry-cocoa copied to clipboard

[WIP] Convert url request to Swift

Open noahsmartin opened this issue 6 months ago • 2 comments

:scroll: Description

:bulb: Motivation and Context

:green_heart: How did you test it?

:pencil: Checklist

You have to check all boxes before merging:

  • [ ] I added tests to verify the changes.
  • [ ] No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • [ ] I updated the docs if needed.
  • [ ] I updated the wizard if needed.
  • [ ] Review from the native team if needed.
  • [ ] No breaking change or entry added to the changelog.
  • [ ] No breaking change for hybrid SDKs or communicated to hybrid SDKs.

#skip-changelog

noahsmartin avatar Jun 21 '25 01:06 noahsmartin

Codecov Report

:x: Patch coverage is 97.10145% with 2 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 86.102%. Comparing base (95cfd20) to head (3d3b119). :warning: Report is 627 commits behind head on main.

Files with missing lines Patch % Lines
Sources/Swift/Tools/SentryURLRequestFactory.swift 95.454% 2 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5451       +/-   ##
=============================================
- Coverage   86.221%   86.102%   -0.119%     
=============================================
  Files          399       398        -1     
  Lines        34647     34510      -137     
  Branches     14983     14877      -106     
=============================================
- Hits         29873     29714      -159     
- Misses        4726      4755       +29     
+ Partials        48        41        -7     
Files with missing lines Coverage Δ
Sources/Sentry/SentryHttpTransport.m 98.154% <100.000%> (-0.007%) :arrow_down:
Sources/Sentry/SentrySpotlightTransport.m 78.571% <100.000%> (-0.739%) :arrow_down:
Sources/Sentry/SentryTransportFactory.m 100.000% <ø> (ø)
Sources/Swift/Tools/SentryURLRequestBuilder.swift 100.000% <100.000%> (ø)
Sources/Swift/Tools/SentryURLRequestFactory.swift 95.454% <95.454%> (ø)

... and 26 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 95cfd20...3d3b119. Read the comment docs.

codecov[bot] avatar Jun 21 '25 02:06 codecov[bot]

Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 1209.57 ms 1231.88 ms 22.31 ms
Size 23.75 KiB 849.08 KiB 825.34 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c5232eadff3e28f984b91f2f5ce629ad7381aad1 1226.06 ms 1246.57 ms 20.50 ms
464117d76c03363a8a5699b3edd07c57398c9518 1240.46 ms 1252.91 ms 12.45 ms
94e1968f3d4f4f1e1889efef776458ac3b0157b2 1230.22 ms 1253.33 ms 23.11 ms
3ea21f5004b1b347fe430434d623860de393f15f 1250.80 ms 1258.88 ms 8.08 ms
b1783fd3e447cebe342a4bc2c49e7ea0db3d282e 1216.67 ms 1238.75 ms 22.08 ms
794f87ff4fbac22a85fdfb6fa78d2f10479f03c2 1225.78 ms 1243.46 ms 17.68 ms
17afc4b3c47807a1cf8010aab1faffd6c99ae97a 1228.94 ms 1251.10 ms 22.16 ms
6e31b7c796f20edaf39ba795667596e7bf876c43 1230.80 ms 1246.29 ms 15.49 ms
25e00aa395feb46c07df40f02805b43c8fd716cd 1236.98 ms 1250.98 ms 14.00 ms
4c00f8ce3aa9f8bb8560977533e170613df5d397 1231.62 ms 1237.76 ms 6.14 ms

App size

Revision Plain With Sentry Diff
c5232eadff3e28f984b91f2f5ce629ad7381aad1 22.85 KiB 413.98 KiB 391.13 KiB
464117d76c03363a8a5699b3edd07c57398c9518 21.58 KiB 705.40 KiB 683.82 KiB
94e1968f3d4f4f1e1889efef776458ac3b0157b2 21.58 KiB 614.74 KiB 593.15 KiB
3ea21f5004b1b347fe430434d623860de393f15f 22.84 KiB 402.63 KiB 379.78 KiB
b1783fd3e447cebe342a4bc2c49e7ea0db3d282e 22.31 KiB 818.59 KiB 796.28 KiB
794f87ff4fbac22a85fdfb6fa78d2f10479f03c2 20.76 KiB 401.37 KiB 380.61 KiB
17afc4b3c47807a1cf8010aab1faffd6c99ae97a 20.76 KiB 436.25 KiB 415.49 KiB
6e31b7c796f20edaf39ba795667596e7bf876c43 21.58 KiB 614.65 KiB 593.07 KiB
25e00aa395feb46c07df40f02805b43c8fd716cd 23.76 KiB 821.43 KiB 797.67 KiB
4c00f8ce3aa9f8bb8560977533e170613df5d397 20.76 KiB 419.62 KiB 398.86 KiB

Previous results on branch: convertURLRequestToSwift

Startup times

Revision Plain With Sentry Diff
d06ea1f40da4840030a2681ee6b0c709cf40aae6 1217.63 ms 1235.61 ms 17.98 ms

App size

Revision Plain With Sentry Diff
d06ea1f40da4840030a2681ee6b0c709cf40aae6 23.75 KiB 849.07 KiB 825.33 KiB

github-actions[bot] avatar Jun 21 '25 02:06 github-actions[bot]

I am not sure right now if you want us to review this, as the title indicates WIP but the PR is marked as ready-for-review. Please clarify.

philprime avatar Jun 23 '25 08:06 philprime